Export include folder #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uttarayan21 would you please sign the Contributor License Agreement? I'd like to merge this, but I am not allowed to without your signature. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 9 9
Lines 1763 1763
=======================================
Hits 1730 1730
Misses 33 33 ☔ View full report in Codecov by Sentry. |
|
Hi, @scouten-adobe I've signed the Adobe CLA. Sorry about the delay I was out for a few days. |
|
No worries. I'm out on break today but should be able to review tonight or tomorrow. |
scouten-adobe
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Added the links keyword to the Cargo.toml and export the include dir in build.rs
Needed when compiling other c / c++ libraries with a rust wrapper which link to xmp_toolkit or include headers ( for e.g. dng-sdk )
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.