Merge main into feds gnav (#436)

* MWPW-122131 - Embed Blocks (#348) * add twitter auto_block * add tiktok * add tiktok test * add vimeo * add instagram * add slideshare * minor fix * fix vimeo player link * fix vimeo url check * PR feedback Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> * MWPW-120782 - Fix Chart Color Order (#393) * MWPW-109331 - Carousel (#375) * Carousel v1 * PR feedback, clean up * PR feedback. Clean up. Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * MWPW-124631 check if adobe logo block exists in document (#406) check if adobe logo block exists in doc * Migrate Walls.io (#378) * add walls.io block * add test * fix css * fix url vulnerability * pr feedback * fix vulnerability * pr feedback * MWPW-124632 [Milo] No character count in the review component text box (#407) * MWPW-124584 (#411) Co-authored-by: Blaine Gunn <gunn@adobe.com> * MWPW-124845 - Start Project button missing for only some projects (#409) MWPW-124845 - Start Project button missing for only English Copy Projects - update start button show condition to handle the case where there are no translation projects Resolves: MWPW-124845 * MWPW-124277 - Link Localization not working for some links in Gnav and Footer (#396) - call decorateLinks for gnav in gnav init instead of individual blocks - removed decorateSVG and localizeLink instances as it is called in decorateLinks - added tests to verify link localization in gnav menu, breadcrumb, cta, brand link - call decorateLinks for footer links in init method - added try catch in utils for empty href or malformed href - fix https://business.adobe.com/au getting converted to https://business.adobe.com/au/au - add test for this fix - Support www.adobe.com link localization and add test for the same Resolves: MWPW-124277 * MWPW-124277 - Regression Fix Link Localization (#416) MWPW-124277 - Regression Fix Link Localization for - Retaining the per menu localize link to avoid regression issue noticed with few links not being localized. Resolves: MWPW-124277 * MWPW-123893 - Review Schema (#415) * Add product schema to review block * MWPW-123745 SVG alt text (#401) * MWPW-123745 SVG alt text Added feature to svg images to allow for authors to add alt text. * PR feedback Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Chris Millar <cmillar@adobe.com> * MWPW-120020 - Event-driven Modals (#403) * Ability to open a modal with a custom event * Ability to customize the look and behavior of a modal * Turned GeoRouting on for Milo * MWPW-1224169 Updated How-to block (#404) * MWPW-1224169 Updated How-to block * Fix tests; Update ld json * Update inline image size * Die gracefully with old format * full backwards compatibility Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com> * small windows fix (#418) * MWPW-123760 (#383) Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * MWPW-124906 - Embed links inside text block (#420) Co-authored-by: Chris Millar <cmillar@adobe.com> * MWPW-124846 - Loc Support fragments at any level in hierarchy (#419) Co-authored-by: bhagwath <bhagwath@adobe.com> * MWPW-125032 Brand Block: using an SVG link for logo breaks gnav rendering (#422) * MWPW-120802 - Diagonal Labels for Chart (#412) * MWPW-120802 - Diagonal Labels for Chart * pr * Add asset support to library * Add Franklin customer library support * Remove 3rd party libraries if not used * Add utils test coverage (#427) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * A simple `reading-time` block to estimate the reading time of the article (#356) * A simple block to estimate the reading time of the article * reading-time: typo in the css * reading-time: small change to the css * reading-time PR review changes * added placeholders for localization of the '5 min read' text * [reading-time]: add a placeholder key for singular reading time value * [reading-time]: less strict scoping for css * [reading-time]: less strict scoping for css * [reading-time]: text-align center only if it's in a center section * reading-time tests added * reading-time tests added * Fixing bug for faas import from link clicked. (#424) * Fixing bug for faas import from link clicked. * adding ||= sytex. * same as before. * MWPW-122611 - [GH Action] Old browser function detection (#423) * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions --------- Co-authored-by: Aaron Mauchley <mauchley@adobe.com> * removing display none from accordion (#433) --------- Co-authored-by: Saugat Malla <saugat013@gmail.com> Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Mirko Sagolj <37147400+msagolj@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Blaine Gunn <gunn@adobe.com> Co-authored-by: Janaki R Bhagwath <janaki.r.bhagwath@gmail.com> Co-authored-by: bhagwath <bhagwath@adobe.com> Co-authored-by: Solène <62023521+So1ene@users.noreply.github.com> Co-authored-by: Sean Choi <seanchoi@adobe.com> Co-authored-by: jckautzmann <jkautzma@adobe.com> Co-authored-by: Aaron Mauchley <mauchley@adobe.com> Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com>
adobecom · Feb 2, 2023 · 91146cf · 91146cf
1 parent 0786395
commit 91146cf
Show file tree

Hide file tree

Showing 81 changed files with 2,941 additions and 438 deletions.
diff --git a/.browserslistrc b/.browserslistrc
@@ -0,0 +1,5 @@
+last 1 chrome version
+last 1 firefox version
+last 1 edge version
+safari >= 14
+ios_saf >= 14
diff --git a/.eslintrc-code-compatibility.js b/.eslintrc-code-compatibility.js
@@ -0,0 +1,16 @@
+module.exports = {
+  root: true,
+  extends: ['plugin:compat/recommended', 'plugin:ecmalist/recommended'],
+  settings: { es: { aggressive: true } },
+  env: { browser: true, mocha: true },
+  parser: '@babel/eslint-parser',
+  parserOptions: {
+    allowImportExportEverywhere: true,
+    sourceType: 'module',
+    requireConfigFile: false,
+  },
+  ignorePatterns: [
+    '/libs/deps/*',
+    '/tools/loc/*',
+  ],
+};
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,6 +1,7 @@
 module.exports = {
   root: true,
-  extends: ['airbnb-base', 'plugin:react-hooks/recommended'],
+  extends: ['airbnb-base', 'plugin:react-hooks/recommended', 'plugin:compat/recommended', 'plugin:ecmalist/recommended'],
+  settings: { es: { aggressive: true } },
   env: { browser: true, mocha: true },
   parser: '@babel/eslint-parser',
   parserOptions: {

diff --git a/.github/workflows/code-compatibility.yaml b/.github/workflows/code-compatibility.yaml
@@ -0,0 +1,25 @@
+name: Check code compatibility with Milo supported browsers
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  check:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Check for unsupported functions
+        run: |
+          # Install eslint and its plugins
+          npm install
+
+          # Check for unsupported functions in the code
+          npx eslint --no-eslintrc -c .eslintrc-code-compatibility.js .
diff --git a/libs/blocks/accordion/accordion.css b/libs/blocks/accordion/accordion.css
@@ -8,10 +8,6 @@
   color: #FFFFFF;
 }
 
-div.accordion {
-  display: none;
-}
-
 dl.accordion {
   max-width: var(--grid-container-width);
   margin: 0 auto;

diff --git a/libs/blocks/card/card.js b/libs/blocks/card/card.js
@@ -1,6 +1,6 @@
 import { decorateButtons } from '../../utils/decorate.js';
 import { loadStyle, getConfig, createTag } from '../../utils/utils.js';
-import { getSectionMetadata } from '../section-metadata/section-metadata.js';
+import { getMetadata } from '../section-metadata/section-metadata.js';
 
 const HALF = 'OneHalfCard';
 const HALF_HEIGHT = 'HalfHeightCard';
@@ -19,8 +19,10 @@ const getCardType = (styles) => {
 };
 
 const getUpFromSectionMetadata = (section) => {
-  const sectionMetadata = getSectionMetadata(section.querySelector('.section-metadata'));
-  const styles = sectionMetadata.style?.split(', ').map((style) => style.replaceAll(' ', '-'));
+  const sectionMetadata = section.querySelector('.section-metadata');
+  if (!sectionMetadata) return null;
+  const metadata = getMetadata(sectionMetadata);
+  const styles = metadata.style?.text.split(', ').map((style) => style.replaceAll(' ', '-'));
   return styles?.find((style) => style.includes('-up'));
 };