removing display none from accordion #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullcolorcoder
added
bug
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
ryanmparrish
approved these changes
Feb 1, 2023
rgclayton
approved these changes
Feb 1, 2023
mokimo
added a commit
that referenced
this pull request
Feb 2, 2023
* MWPW-122131 - Embed Blocks (#348) * add twitter auto_block * add tiktok * add tiktok test * add vimeo * add instagram * add slideshare * minor fix * fix vimeo player link * fix vimeo url check * PR feedback Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> * MWPW-120782 - Fix Chart Color Order (#393) * MWPW-109331 - Carousel (#375) * Carousel v1 * PR feedback, clean up * PR feedback. Clean up. Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * MWPW-124631 check if adobe logo block exists in document (#406) check if adobe logo block exists in doc * Migrate Walls.io (#378) * add walls.io block * add test * fix css * fix url vulnerability * pr feedback * fix vulnerability * pr feedback * MWPW-124632 [Milo] No character count in the review component text box (#407) * MWPW-124584 (#411) Co-authored-by: Blaine Gunn <gunn@adobe.com> * MWPW-124845 - Start Project button missing for only some projects (#409) MWPW-124845 - Start Project button missing for only English Copy Projects - update start button show condition to handle the case where there are no translation projects Resolves: MWPW-124845 * MWPW-124277 - Link Localization not working for some links in Gnav and Footer (#396) - call decorateLinks for gnav in gnav init instead of individual blocks - removed decorateSVG and localizeLink instances as it is called in decorateLinks - added tests to verify link localization in gnav menu, breadcrumb, cta, brand link - call decorateLinks for footer links in init method - added try catch in utils for empty href or malformed href - fix https://business.adobe.com/au getting converted to https://business.adobe.com/au/au - add test for this fix - Support www.adobe.com link localization and add test for the same Resolves: MWPW-124277 * MWPW-124277 - Regression Fix Link Localization (#416) MWPW-124277 - Regression Fix Link Localization for - Retaining the per menu localize link to avoid regression issue noticed with few links not being localized. Resolves: MWPW-124277 * MWPW-123893 - Review Schema (#415) * Add product schema to review block * MWPW-123745 SVG alt text (#401) * MWPW-123745 SVG alt text Added feature to svg images to allow for authors to add alt text. * PR feedback Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Chris Millar <cmillar@adobe.com> * MWPW-120020 - Event-driven Modals (#403) * Ability to open a modal with a custom event * Ability to customize the look and behavior of a modal * Turned GeoRouting on for Milo * MWPW-1224169 Updated How-to block (#404) * MWPW-1224169 Updated How-to block * Fix tests; Update ld json * Update inline image size * Die gracefully with old format * full backwards compatibility Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com> * small windows fix (#418) * MWPW-123760 (#383) Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * MWPW-124906 - Embed links inside text block (#420) Co-authored-by: Chris Millar <cmillar@adobe.com> * MWPW-124846 - Loc Support fragments at any level in hierarchy (#419) Co-authored-by: bhagwath <bhagwath@adobe.com> * MWPW-125032 Brand Block: using an SVG link for logo breaks gnav rendering (#422) * MWPW-120802 - Diagonal Labels for Chart (#412) * MWPW-120802 - Diagonal Labels for Chart * pr * Add asset support to library * Add Franklin customer library support * Remove 3rd party libraries if not used * Add utils test coverage (#427) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * A simple `reading-time` block to estimate the reading time of the article (#356) * A simple block to estimate the reading time of the article * reading-time: typo in the css * reading-time: small change to the css * reading-time PR review changes * added placeholders for localization of the '5 min read' text * [reading-time]: add a placeholder key for singular reading time value * [reading-time]: less strict scoping for css * [reading-time]: less strict scoping for css * [reading-time]: text-align center only if it's in a center section * reading-time tests added * reading-time tests added * Fixing bug for faas import from link clicked. (#424) * Fixing bug for faas import from link clicked. * adding ||= sytex. * same as before. * MWPW-122611 - [GH Action] Old browser function detection (#423) * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions --------- Co-authored-by: Aaron Mauchley <mauchley@adobe.com> * removing display none from accordion (#433) --------- Co-authored-by: Saugat Malla <saugat013@gmail.com> Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Mirko Sagolj <37147400+msagolj@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Blaine Gunn <gunn@adobe.com> Co-authored-by: Janaki R Bhagwath <janaki.r.bhagwath@gmail.com> Co-authored-by: bhagwath <bhagwath@adobe.com> Co-authored-by: Solène <62023521+So1ene@users.noreply.github.com> Co-authored-by: Sean Choi <seanchoi@adobe.com> Co-authored-by: jckautzmann <jkautzma@adobe.com> Co-authored-by: Aaron Mauchley <mauchley@adobe.com> Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com>
sukamat
pushed a commit
to sukamat/milo
that referenced
this pull request
Feb 8, 2023
sukamat
pushed a commit
to sukamat/milo
that referenced
this pull request
Feb 8, 2023
base project page placeholder fg css connect to SP and init floodgate project Reads the floodgate project and injects SP data Add asset support to library Add Franklin customer library support Remove 3rd party libraries if not used Add utils test coverage (adobecom#427) Co-authored-by: Ryan Clayton <rclayton@adobe.com> A simple `reading-time` block to estimate the reading time of the article (adobecom#356) * A simple block to estimate the reading time of the article * reading-time: typo in the css * reading-time: small change to the css * reading-time PR review changes * added placeholders for localization of the '5 min read' text * [reading-time]: add a placeholder key for singular reading time value * [reading-time]: less strict scoping for css * [reading-time]: less strict scoping for css * [reading-time]: text-align center only if it's in a center section * reading-time tests added * reading-time tests added Fixing bug for faas import from link clicked. (adobecom#424) * Fixing bug for faas import from link clicked. * adding ||= sytex. * same as before. MWPW-122611 - [GH Action] Old browser function detection (adobecom#423) * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions --------- Co-authored-by: Aaron Mauchley <mauchley@adobe.com> removing display none from accordion (adobecom#433) Media & Z-Pattern updates - content margins and 2-5up grid support (adobecom#429) * updates to media to support section meta two-five ups * updated default margins * Added detail styles to text-transform:uppercase Removed redundant asside styles. * test coverate on image w/ out alt text --------- Co-authored-by: thi64146 <thi64146@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Update node to v18 (adobecom#440) MWPW-125458 - Adding chat icon (adobecom#439) Adding chat icon for bacom use Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> MWPW-124813 Prevent long breadcrumbs overlapping search (adobecom#434) MWPW-124277: Localize Gnav Sign In Link (adobecom#432) - Call decorateLinks for gnav sign in Resolves: MWPW-124277 add ignores similar to loc project details table markup updated removed console logs updated admin page to keep just the copy action removed copy files placeholder code clean up and loc config import fix cleanup rename app.js to ui.js floodgate content display updated cleanup removed window.projectDetail refactor
chrischrischris
pushed a commit
to adobecom/milo-target
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small patch to remove unnecessary display:none from accordion css that was causing clash with other components.
Test URLs:
Before: https://main--milo--adobecom.hlx.page/drafts/bradjohn/accordion-how-to?martech=off
After: https://accordion-patch--milo--adobecom.hlx.page/drafts/bradjohn/accordion-how-to?martech=off
Bacom