-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-109331 - Carousel #375
Conversation
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 98.91% 98.92% +0.01%
==========================================
Files 78 78
Lines 20367 20745 +378
==========================================
+ Hits 20145 20523 +378
Misses 222 222
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
libs/blocks/carousel/carousel.js
Outdated
btnsArray.push(previousBtn, nextBtn); | ||
return btnsArray; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
btnsArray.push(previousBtn, nextBtn); | |
return btnsArray; | |
return [previousBtn, nextBtn]; |
libs/blocks/carousel/carousel.js
Outdated
|
||
el.append(...nextPreviousBtns, controlsContainer); | ||
|
||
parentArea.addEventListener('milo:deferred', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the event listener be removed after milo:deferred
has fired?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That event only fires once per page.
cc: @auniverseaway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may as well remove the event listener in that case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job - the carousel is super robust in my opinion.
I found a few small nitpicked things and I saw the unit tests are failing, but after that it should be good.
parentArea.addEventListener('milo:deferred', () => { | ||
const images = el.querySelectorAll('img[loading="lazy"]'); | ||
images.forEach((img) => { | ||
img.removeAttribute('loading'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove the loading lazy from the images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was causing a flicker on images inside of the Carousel when you advanced to a slide that contained images. Due to them not loading until they came in to view.
@@ -509,6 +511,8 @@ async function loadPostLCP(config) { | |||
} | |||
|
|||
export async function loadDeferred(area, blocks, config) { | |||
const event = new Event('milo:deferred'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really like this idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another great idea from @auniverseaway
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great, I've got nothing. Nice job!
|
* MWPW-122131 - Embed Blocks (#348) * add twitter auto_block * add tiktok * add tiktok test * add vimeo * add instagram * add slideshare * minor fix * fix vimeo player link * fix vimeo url check * PR feedback Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> * MWPW-120782 - Fix Chart Color Order (#393) * MWPW-109331 - Carousel (#375) * Carousel v1 * PR feedback, clean up * PR feedback. Clean up. Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * MWPW-124631 check if adobe logo block exists in document (#406) check if adobe logo block exists in doc * Migrate Walls.io (#378) * add walls.io block * add test * fix css * fix url vulnerability * pr feedback * fix vulnerability * pr feedback * MWPW-124632 [Milo] No character count in the review component text box (#407) * MWPW-124584 (#411) Co-authored-by: Blaine Gunn <gunn@adobe.com> * MWPW-124845 - Start Project button missing for only some projects (#409) MWPW-124845 - Start Project button missing for only English Copy Projects - update start button show condition to handle the case where there are no translation projects Resolves: MWPW-124845 * MWPW-124277 - Link Localization not working for some links in Gnav and Footer (#396) - call decorateLinks for gnav in gnav init instead of individual blocks - removed decorateSVG and localizeLink instances as it is called in decorateLinks - added tests to verify link localization in gnav menu, breadcrumb, cta, brand link - call decorateLinks for footer links in init method - added try catch in utils for empty href or malformed href - fix https://business.adobe.com/au getting converted to https://business.adobe.com/au/au - add test for this fix - Support www.adobe.com link localization and add test for the same Resolves: MWPW-124277 * MWPW-124277 - Regression Fix Link Localization (#416) MWPW-124277 - Regression Fix Link Localization for - Retaining the per menu localize link to avoid regression issue noticed with few links not being localized. Resolves: MWPW-124277 * MWPW-123893 - Review Schema (#415) * Add product schema to review block * MWPW-123745 SVG alt text (#401) * MWPW-123745 SVG alt text Added feature to svg images to allow for authors to add alt text. * PR feedback Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Chris Millar <cmillar@adobe.com> * MWPW-120020 - Event-driven Modals (#403) * Ability to open a modal with a custom event * Ability to customize the look and behavior of a modal * Turned GeoRouting on for Milo * MWPW-1224169 Updated How-to block (#404) * MWPW-1224169 Updated How-to block * Fix tests; Update ld json * Update inline image size * Die gracefully with old format * full backwards compatibility Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com> * small windows fix (#418) * MWPW-123760 (#383) Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * MWPW-124906 - Embed links inside text block (#420) Co-authored-by: Chris Millar <cmillar@adobe.com> * MWPW-124846 - Loc Support fragments at any level in hierarchy (#419) Co-authored-by: bhagwath <bhagwath@adobe.com> * MWPW-125032 Brand Block: using an SVG link for logo breaks gnav rendering (#422) * MWPW-120802 - Diagonal Labels for Chart (#412) * MWPW-120802 - Diagonal Labels for Chart * pr * Add asset support to library * Add Franklin customer library support * Remove 3rd party libraries if not used * Add utils test coverage (#427) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * A simple `reading-time` block to estimate the reading time of the article (#356) * A simple block to estimate the reading time of the article * reading-time: typo in the css * reading-time: small change to the css * reading-time PR review changes * added placeholders for localization of the '5 min read' text * [reading-time]: add a placeholder key for singular reading time value * [reading-time]: less strict scoping for css * [reading-time]: less strict scoping for css * [reading-time]: text-align center only if it's in a center section * reading-time tests added * reading-time tests added * Fixing bug for faas import from link clicked. (#424) * Fixing bug for faas import from link clicked. * adding ||= sytex. * same as before. * MWPW-122611 - [GH Action] Old browser function detection (#423) * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions --------- Co-authored-by: Aaron Mauchley <mauchley@adobe.com> * removing display none from accordion (#433) --------- Co-authored-by: Saugat Malla <saugat013@gmail.com> Co-authored-by: Chris Millar <cmillar@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: Mirko Sagolj <37147400+msagolj@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Blaine Gunn <gunn@adobe.com> Co-authored-by: Janaki R Bhagwath <janaki.r.bhagwath@gmail.com> Co-authored-by: bhagwath <bhagwath@adobe.com> Co-authored-by: Solène <62023521+So1ene@users.noreply.github.com> Co-authored-by: Sean Choi <seanchoi@adobe.com> Co-authored-by: jckautzmann <jkautzma@adobe.com> Co-authored-by: Aaron Mauchley <mauchley@adobe.com> Co-authored-by: Brad Johnson <fullcolorcoder@gmail.com>
Milo Carousel
Resolves: MWPW-109331
Test URLs:
BACOM Test URLs: