LPS-68460 #367
LPS-68460 #367
Conversation
Sent from 
|
Just started reviewing :) |
|
Hey @BryanEngler. I wasn't aware of that, and I'm pretty sure you're going to be right. Any place where we're following this pattern is likely to be affected. Could you please verify that and create a ticket for it? However, the fact that it happens in other places, doesn't grant fixing it this way. We intentionally made this change because the previous behaviour enforces some bad html practices that we're trying to correct. The rationale for this is explained in the Breaking Changes document. In this particular case, if I understood it correctly, we'd be creating to inputs inside a form:
We'd be creating two inputs, none of which we really need and force both the client and server side to have some additional knowledge about our taglib internals to get it right. By staying closer to how checkboxes in forms work we can simplify both the client and the server side. |
|
sounds good, thanks for the info! ill create a ticket and also look to see if there are any other places where we can find the issue. |
|
Pull request submitted to brianchandotcom#44183. See changes here. |
Hey @adolfopa,
I'm forwarding you this so you can keep track of it.
As we discussed, the fix should be applied on the Message Boards App, so this fix should be removed for a more specific one.
Thanks!