Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Allow watch override ignore directories #134

Closed
McSneaky opened this issue Apr 26, 2019 · 2 comments
Closed

Allow watch override ignore directories #134

McSneaky opened this issue Apr 26, 2019 · 2 comments
Assignees

Comments

@McSneaky
Copy link

McSneaky commented Apr 26, 2019

Why this feature is required (specific use-cases will be appreciated)?

Currently there is no way for Adonis CLI to watch for tmp, resources and public folders. Since they are hard-coded into ignore list.

It would be nice, if you can add them with --watch or files in them with --ext.
Since in underlying nodemon ignore list has power over watch list files and folders. nodemon faq

It would be especially good for .edge files development in resource files

Have you tried any other work arounds?

Tried adonis serve -w /resources/* which did not work.
Also adonis serve --dev --ext edge does not work

There is possibility to add custom script into package.json but it is not as clean as using Adonis CLI. It would require installing nodemon (or anything similar) and nodemon.json config file

Are you willing to work on it with little guidance?

Yes.
Already fixed it on my fork. Not sure if it is acceptable tho

McSneaky added a commit to McSneaky/adonis-cli that referenced this issue Apr 26, 2019
Allow --watch to override files and folders in default ignore list

fix adonisjs#134
@thetutlage
Copy link
Member

The edge files doesn't need the server to be restarted, since they are compiled on every Http request (when CACHE_VIEWS=false).

Also, the resources folder is mainly in place for frontend related code, is their any specific reason you want to start AdonisJs server when your frontend code changes.

It will be nice to have some real world examples

@thetutlage thetutlage self-assigned this Apr 26, 2019
@McSneaky
Copy link
Author

Aaaah.. Stupid me 😄

Didn't think about views cache.. Disabling it and all works as intended

I can't figure out currently any more use-cases for it currently. If someone has any then it might come handy.

From my point of view it can be closed 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants