This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
feat(ignitor): add loadOnlyOnHttp file list #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋
This add a way to disable the loading of some files when using Ignitor to fire Ace Command.
In the current implementation, having
socket.js
to be preloaded when running ace could prevent Node to exit the process if your code start any long-living connection.On this PR, the test works but it seems that it's testing nothing. After some debugging it seems that some tests are green without really testing something.
Also, the test
load ace providers when fireAce command is called
seems to not work anymore because theRequire Stack
is added to the exception's message.