feat: export type for LoggerLevel (pino.Level) from root module #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
None, as this is a very small change.
β Type of change
π Description
Whilst working on a kafka package for Adonis v6, I needed the ability to type a
KAFKA_LOG_LEVEL
value, which is the same as the Pino log levels. I thought I could just do:But this doesn't work, instead I'd need to add
@adonisjs/logger
as adevDependency
andpeerDependency
to our project, instead of just relying on@adonisjs/core
, and then change that type import to:I feel like the former is probably a more expected way to use this type, hence opening this pull request.
π Checklist