Optimize empty sessions

[Dlahacz]

Proposed changes

Hi,
We have eliminated storing of approximately 20 million empty sessions in our production, each resembling the following structure: {"message": {}, "purpose": "xxx"}. Although a single session consumed "only" 128 bytes, the combined reduction in Redis memory usage was amounted to about 2.5 GB. This was achieved by deleting the session key rather than storing an empty object in Redis. We are currently unaware of any potential side effects and have implemented this as custom session driver in our production deployment.

Types of changes

What types of changes does your code introduce?

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• I have read the CONTRIBUTING doc
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works.
• I have added necessary documentation (if appropriate)

[RomainLanz]

LGTM, but I don't have a broad view of this change.

Quick one, why not call this.destroy instead of duplicating the del call?

[thetutlage]

Yeah, seems fine to me as well. Basically,

If session is empty, then it is not persisted to any store. How about make the same change with the file driver as well for the sake for consistency?

[Dlahacz]

Sure, we'll work on it little bit more.

[Dlahacz]

@thetutlage What do you think about moving that logic into session.commitValuesToStore() or session.commit(). Should we make it global or rather keep it in each driver?

[RomainLanz]

Yeah, making it global seems a better choice to avoid duplicating code.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[RomainLanz]

This has been considered for the next release (working with AdonisJS 6).
Closing this one since no answer from the initial author.