[Feature] Warning Validators

[offirgolan]

Use Case:

You have a password field with a length validator of { min: 4, max: 10 } but want to display a warning telling the user their password is hella weak if its under 6 characters.

Solution:

Warning validators!

How it works:

• They should be declared like any other validator
• Act like an assert. If the conditions are unsatisfied, should return an error message (just like any validator)
• These validators will be filtered out of the "required" validators and all messages will be put in the warnings collection.
• It should be up to the user when to display those warnings but they will not have any effect on the overall valid state of the attribute.

Usage:

password: {
  description: 'Password',
  validators: [
    validator('length', {
      min: 4,
      max: 10
    }),
    validator('length', {
      isWarning: true,
      min: 6,
      message: 'What kind of weak password is that?'
    })
  ]
}

@rwjblue @stefanpenner @blimmer I would love to hear some input from your guys. Questions, concerns, whatever

[offirgolan]

Questions that need answering:

1. Is warning the right property to have? Maybe required or severity?
2. Which attributes in result-collection.js should be dependent on required validations or on all validations? From what I feel like, all promise related attribute should be dependent on all validators, that way they all resolve together?

[blimmer]

is .0 the right thing to use here? I've always used firstObject.

[offirgolan]

This is the same code that is the errors and error CPs. I believe I tried firstObject but it errored on me. Ill give it another shot though.

[blimmer]

No problem - definitely not required, I just haven't seen this syntax before.

[stefanpenner]

firstObject ideally

[stefanpenner]

firstObject

[stefanpenner]

thoughts on warning: true -> isWarning: true?

[offirgolan]

@stefanpenner 👍