-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep link syntax to preselect JDK version #373
Comments
I have also described it here: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1152 |
I've created #379 as a starting point, it will at least allow you to manually pass |
I suggest we proceed with this direction, and modify so that:
WDYT? (*) I say this, because the drop down explainer text is in the releases.js file, so that would have to be moved and optionally excluded too in DownloadDropdowns.tsx |
@tellison From the users point of view I would prefer if the drop-downs are still visible and can be modified. If the user wants to change the version filter this proposal would mean he needs to go to the browser URL (which is mostly hidden nowadays) and manually remove or edit the query parameters. |
@marchof ok, that will require pushing the new version URL to the browser, which is fine. Question is whether that should form part of the history too, so back button reloads previous version selection, or not (history pushstate vs. history replaceState). @gdams and I also discussing if it is only the version that should be parameterised in the URL. |
For the record, the decision was the replace state, and we'll handle the variant param in a separate PR. |
I think I know where the wrong referrals came from, sorry. 🙈 It's fixed now with the new parameters: https://javaalmanac.io/jdk/18/ |
I see that, thanks for making the update. |
I guess OS pre-selection was deemed unnecessary? |
Dear adoptium team,
Marc here from javaalmanac.io. I noticed that my deep links to adoptium.net stopped working. So what I basically do is to offer users direct links to different distrubutions, for example:
https://javaalmanac.io/jdk/11/
Is the a possibility to pre-select for example Version 11 on your download page? For example something like
https://adoptium.net/temurin/releases?version=11
Thanks for your great work,
-marc
The text was updated successfully, but these errors were encountered: