Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep link syntax to preselect JDK version #373

Closed
marchof opened this issue Apr 11, 2022 · 10 comments · Fixed by #379
Closed

Deep link syntax to preselect JDK version #373

marchof opened this issue Apr 11, 2022 · 10 comments · Fixed by #379

Comments

@marchof
Copy link

marchof commented Apr 11, 2022

Dear adoptium team,

Marc here from javaalmanac.io. I noticed that my deep links to adoptium.net stopped working. So what I basically do is to offer users direct links to different distrubutions, for example:

https://javaalmanac.io/jdk/11/

Is the a possibility to pre-select for example Version 11 on your download page? For example something like

https://adoptium.net/temurin/releases?version=11

Thanks for your great work,
-marc

@rafrafek
Copy link

I have also described it here: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1152

@gdams gdams linked a pull request Apr 12, 2022 that will close this issue
@gdams
Copy link
Member

gdams commented Apr 12, 2022

I've created #379 as a starting point, it will at least allow you to manually pass ?version=11 to the URL's to preselect a JDK version

@gdams gdams mentioned this issue Apr 23, 2022
@tellison
Copy link
Contributor

I suggest we proceed with this direction, and modify so that:

  1. Extend so OS, CPU, package type, and Java version can optionally be passed as URL query parameters; and
  2. When we detect that query params have been passed, we do not show the drop downs on the page (or as a first step set the disabled attribute(*)), thereby removing the problem of having to update the URL if users choose to change the options via drop downs.

WDYT?

(*) I say this, because the drop down explainer text is in the releases.js file, so that would have to be moved and optionally excluded too in DownloadDropdowns.tsx

@marchof
Copy link
Author

marchof commented May 16, 2022

@tellison From the users point of view I would prefer if the drop-downs are still visible and can be modified. If the user wants to change the version filter this proposal would mean he needs to go to the browser URL (which is mostly hidden nowadays) and manually remove or edit the query parameters.

@tellison
Copy link
Contributor

@marchof ok, that will require pushing the new version URL to the browser, which is fine.

Question is whether that should form part of the history too, so back button reloads previous version selection, or not (history pushstate vs. history replaceState).

@gdams and I also discussing if it is only the version that should be parameterised in the URL.
We are getting 20% of current referral links coming in with variant=openjdk11, which will show Java 17 at the moment as our param is called version=11. I guess it keeps them up to date :-)

@tellison
Copy link
Contributor

For the record, the decision was the replace state, and we'll handle the variant param in a separate PR.

@marchof
Copy link
Author

marchof commented May 16, 2022

I think I know where the wrong referrals came from, sorry. 🙈

It's fixed now with the new parameters: https://javaalmanac.io/jdk/18/

@tellison
Copy link
Contributor

I think I know where the wrong referrals came from, sorry. 🙈

It's fixed now with the new parameters: https://javaalmanac.io/jdk/18/

I see that, thanks for making the update.

@Jackenmen
Copy link

I guess OS pre-selection was deemed unnecessary?

@rafrafek
Copy link

?version=11 is not enough. Link should include all the parameters:

  • Operating System
  • Architecture
  • Package type
  • Version

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants