Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamps to openjdk_tests and remove timestampes from JenkinsfileBase #3501

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

YeeSkywalker
Copy link
Contributor

Sign-off: Yee Lin
Close: #3396

@YeeSkywalker
Copy link
Contributor Author

Grinder link: Grinder/3995

@llxia
Copy link
Contributor

llxia commented Mar 28, 2022

Is this a partial change? I do not see the changes of removing the existing timestamp in https://github.com/adoptium/aqa-tests/blob/master/buildenv/jenkins/JenkinsfileBase

@YeeSkywalker
Copy link
Contributor Author

Is this a partial change? I do not see the changes of removing the existing timestamp in https://github.com/adoptium/aqa-tests/blob/master/buildenv/jenkins/JenkinsfileBase

Sorry I forgot to commit that change. Have updated the latest version PR.

@YeeSkywalker
Copy link
Contributor Author

Grinder test link: Grinder/4171

@llxia
Copy link
Contributor

llxia commented Mar 29, 2022

@YeeSkywalker Sorry to let you know, the PR contains merge conflicts.

@YeeSkywalker
Copy link
Contributor Author

@YeeSkywalker Sorry to let you know, the PR contains merge conflicts.

Have resolved conflicts. Please review when you are available and thank you for your time in advance!

@llxia
Copy link
Contributor

llxia commented Mar 30, 2022

@llxia
Copy link
Contributor

llxia commented Mar 30, 2022

In order to avoid future merge conflicts, I would prefer to get this PR in before any other Jenkins script changes (i.e., #3502 or #3476)

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @YeeSkywalker and @llxia !

@smlambert smlambert merged commit c2c2c04 into adoptium:master Mar 30, 2022
llxia added a commit that referenced this pull request Mar 30, 2022
sophia-guo pushed a commit that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add timestamp{} in test pipeline
3 participants