Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rerun in Grinder with failed test link #3502

Closed
wants to merge 48 commits into from
Closed

Fix rerun in Grinder with failed test link #3502

wants to merge 48 commits into from

Conversation

YeeSkywalker
Copy link
Contributor

Sign-off: Yee Lin
Close: #3449

@YeeSkywalker
Copy link
Contributor Author

YeeSkywalker commented Mar 30, 2022 •
edited

Grinder parallel test link: Grinder/4190. This test ran with jdk18 release and test target were set to testList TESTLIST=jdk_time_2,jdk_tools_2. jdk_time_2 and jdk_tools_2 should fail under jdk18 enviroment. The Rerun in Grinder with failed test targets contained TARGET = testList TESTLIST=jdk_tools_2,jdk_time_2 which was exactly same as initial test target. Please review when you are free!

@smlambert
Copy link
Contributor

Adding another test for this PR, running a similar Grinder, with the 2 failing targets plus a third that is passing, to check that the passing one would not get triggered:

Grinder/4193

llxia
llxia requested changes Mar 30, 2022
View reviewed changes
buildenv/jenkins/JenkinsfileBase Outdated Show resolved Hide resolved
@llxia
Copy link
Contributor

llxia commented Mar 30, 2022

Also, I think the problem only happens if there are extra TAP files in the workspace, so it may not be able to detect all the time. This is why the previous PR testing was fine and we detected the problem in the regular build.

@llxia llxia mentioned this pull request Mar 30, 2022
Merged
@llxia llxia changed the title Rerun in Grinder with failed test link does not have correct test targets Fix rerun in Grinder with failed test link Apr 4, 2022
@YeeSkywalker
Copy link
Contributor Author

YeeSkywalker commented Apr 5, 2022 •
edited

After resolving conflicts, this PR is ready for review.

Please review when you are available and thank you for your time in advance!

@YeeSkywalker
Copy link
Contributor Author

The normal test Grinder/4419, with one failed target jdk_time_2 and one successful target jdk_math with JDK18. The Rerun in Grinder with failed test targets returned TARGET of testList TESTLIST=jdk_time_2

@llxia please review when you are free! Thx for your time in advance.

@llxia
Copy link
Contributor

llxia commented Apr 11, 2022

@YeeSkywalker Could you please resolve merge conflicts? Thanks

llxia
llxia reviewed Apr 11, 2022
View reviewed changes
buildenv/jenkins/JenkinsfileBase
@@ -1026,7 +1036,7 @@ def run_parallel_tests() {
currentBuild.result = buildResult
}
archiveFile("**/*.tap")
addFailedTestsGrinderLink()
addFailedTestsGrinderLink(buildPaths.substring(0, buildPaths.length() - 1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check buildPaths contains the value. Otherwise, we will get IndexOutOfBoundsException.

llxia
llxia reviewed Apr 11, 2022
View reviewed changes
buildenv/jenkins/JenkinsfileBase
def file = readFile(file: "${tapFile}")
TapConsumer tapConsumer = TapConsumerFactory.makeTap13Consumer()
TestSet testSet = tapConsumer.load(file)
echo "Testset ${testSet}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove debugging echo messages.

@YeeSkywalker
Copy link
Contributor Author

@YeeSkywalker Could you please resolve merge conflicts? Thanks

Update with PR#3580

@llxia
Copy link
Contributor

llxia commented Apr 18, 2022

Close this PR as new #3580 is created.

@llxia llxia closed this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rerun in Grinder with failed test link does not have correct test targets
3 participants
@YeeSkywalker @smlambert @llxia