-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rerun in Grinder with failed test link #3502
Conversation
Grinder parallel test link: Grinder/4190. This test ran with jdk18 release and test target were set to |
Adding another test for this PR, running a similar Grinder, with the 2 failing targets plus a third that is passing, to check that the passing one would not get triggered: |
Also, I think the problem only happens if there are extra TAP files in the workspace, so it may not be able to detect all the time. This is why the previous PR testing was fine and we detected the problem in the regular build. |
After resolving conflicts, this PR is ready for review.
Please review when you are available and thank you for your time in advance! |
Testing for normal test path
The normal test Grinder/4419, with one failed target @llxia please review when you are free! Thx for your time in advance. |
@YeeSkywalker Could you please resolve merge conflicts? Thanks |
@@ -1026,7 +1036,7 @@ def run_parallel_tests() { | |||
currentBuild.result = buildResult | |||
} | |||
archiveFile("**/*.tap") | |||
addFailedTestsGrinderLink() | |||
addFailedTestsGrinderLink(buildPaths.substring(0, buildPaths.length() - 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check buildPaths
contains the value. Otherwise, we will get IndexOutOfBoundsException.
def file = readFile(file: "${tapFile}") | ||
TapConsumer tapConsumer = TapConsumerFactory.makeTap13Consumer() | ||
TestSet testSet = tapConsumer.load(file) | ||
echo "Testset ${testSet}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove debugging echo messages.
Update with PR#3580 |
Close this PR as new #3580 is created. |
Sign-off: Yee Lin
Close: #3449