Output generic TEST_JDK_HOME in job.properties

[JeromeJu]

Always output TEST_JDK_HOME into job.properties at get.sh, therefore in JenkinsfileBase the TEST_JDK_HOME would always be read regardless the condition checks.

Fixes: #3128

Sign off by: Jerome Ju jeromeqju@gmail.com

[JeromeJu]

Thanks Lan for the pointers!

[llxia]

@JeromeJu Thanks for the update. We will need to test on xlinux, wins, mac and zos. I will take care of zos. Could you provide Grinder links for the rest of 3 platforms?

[JeromeJu]

Built Success
mac: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3866/

linux: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3865/

Failed with hudson.AbortException
win_x86: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3867/

^^^ Looking into this...

22:21:35       [echo] Ant version is Apache Ant(TM) version 1.10.5 compiled on July 10 2018
22:21:35       [echo] ============COMPILER SETTINGS============
22:21:35       [echo] ===fork:                         yes
22:21:35       [echo] ===debug:                        on
22:21:35      [javac] Compiling 25 source files to E:\workspace\Grinder\aqa-tests\TKG\bin
22:21:35  
22:21:35  BUILD FAILED
22:21:35  E:\workspace\Grinder\aqa-tests\TKG\scripts\build_tools.xml:58: The following error occurred while executing this line:
22:21:35  E:\workspace\Grinder\aqa-tests\TKG\scripts\build_tools.xml:37: Error running \cygdrive\e\workspace\Grinder\aqa-tests\..\openjdkbinary\j2sdk-image\bin\javac compiler
22:21:35  
22:21:35  Total time: 0 seconds
22:21:35  1
22:21:35  make: *** [makefile:94: compileTools] Error 1

[llxia]

zos: /Grinder/21919

[JeromeJu]

I noticed that for the windows_x86,

	    <target name="compile" depends="init,getDependentLibs" description="Using java ${JDK_VERSION} to compile the source  ">
		    <echo>Ant version is ${ant.version}</echo>
		    <echo>============COMPILER SETTINGS============</echo>
		    <echo>===fork:                         yes</echo>
		    <echo>===debug:                        on</echo>
>>>		    <javac srcdir="${src}" destdir="${build}" debug="true" fork="true" executable="${TEST_JDK_HOME}/bin/javac" includeAntRuntime="false" encoding="ISO-8859-1">
			    <classpath>
				    <pathelement location="${json.jar}" />
			    </classpath>
		    </javac>
	    </target>

[llxia]

For windows, could you try with JDK11?

[JeromeJu]

I've added the conversion to windows path from cygpath at https://github.com/JeromeJu/aqa-tests/blob/3128_TEST_JDK_HOME/get.sh#L602-L604.
Now it does ouput the correct windows path into job.properties by cat in another test_3128 branch in https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3910/console.

However, I could not figure out why when the JenkinsfileBase reads it, the slashes are all gone as follow:

[](https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3911/console#)[](https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3911/console#)19:28:46  readProperties file: ./aqa-tests/job.properties
[Pipeline] readProperties
[Pipeline] echo
19:28:47  Set TEST_JDK_HOME to C:UsersJenkinsworkspaceGrinderopenjdkbinaryj2sdk-image

[llxia]

Could you try to add double quotes around TEST_JDK_HOME?

[JeromeJu]

Hi @llxia, I figured it's the redirect issue of backslash in the converted windows paths. I used sed to circumvent that.

Grinder links:
mac: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4215/
linux: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4214/
win: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4213/

Could you plz help rerun the zos as I could not find the params according to your previous job number?

Thanks!

[JeromeJu]

Grinder links after updating to the specific if block for windows.
mac: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4219/
linux: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4220/
win: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4221/

[JeromeJu]

My apologies..... I took the last change too brainless.

win: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4240/
mac: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4242/
linux: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4241/

[llxia]

zos: Grinder/22280

[llxia]

LGTM

[smlambert]

LGTM

[keithc-ca]

I don't think you want -e here. Suppose ${TEST_JDK_HOME} is C:\test\foo\bar, -e will map \t to a tab which isn't likely to work.

[pshipton]

All of a sudden the OpenJ9 testing is failing to run javac, at least on Windows, and this is what changed.
See eclipse-openj9/openj9#14857