-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jtreg artifacts contain incorrect contents #165
Comments
@jerboaa - looking for some assistance with this one if you have time to take it or advise on it, please :) |
Looking at the code both |
This could be fixed by checkout preferred release version https://github.com/adoptium/ci-jenkins-pipelines/blob/master/tools/code-tools/Jenkinsfile#L70 |
@smlambert Are you still looking to get this fixed? If yes, I'll take a look later in the week. |
If you can, that would be great thanks @jerboaa. |
ok |
Note that JDK head now requires jtreg 6, which isn't backwards compatible. I.e. JDK 17+ will have to use jtreg 6 and other JDKs stay with jtreg 5 (should work for JDK 8 and 11). As such, I'm going to update the code to build jtreg 5 and jtreg 6. |
Related: adoptium/aqa-tests#2642 |
I have successful builds available using specific releases https://github.com/openjdk/jtreg/releases https://ci.adoptopenjdk.net/view/work-in-progress/job/GetNode/46/ The tricky thing is the build is building from my personal jtreg branch. https://github.com/sophia-guo/jtreg The reason for that is jtreg set the latest tagged version by default , which also doesn't support passing in extra tag information:
https://github.com/openjdk/jtreg/blob/master/make/build-all.sh#L287-L288 https://github.com/openjdk/jtreg/blob/master/make/build-all.sh#L31-L34 https://github.com/openjdk/jtreg/blob/master/make/build-all.sh#L84-L90 So looks like we need to set up a separate repo if we'd like to build versions other than the latest. Thought? |
I'm not sure we need to. @sophia-guo These two lines look like as if they would respect
|
@jerboaa Thanks! Didn't bother to go further once I saw the line TAG_INFO= |
Just a note that for jtreg 6+ we don't need to export build_number and build_version any more. Specification of version info was added in different version-numbers.txt files. When building use build.sh for jtreg6+ while buildall.sh for jtreg5. Though buildall.sh stays in the jtreg6+, which is confusing. |
The https://ci.adoptopenjdk.net/view/Dependencies/job/dependency_pipeline/lastSuccessfulBuild/artifact/jtreg/ job produces several artifacts, some of them contain incorrect contents.
The Jenkinsfile and jtreg.sh files are in: https://github.com/adoptium/ci-jenkins-pipelines/tree/master/tools/code-tools
The text was updated successfully, but these errors were encountered: