Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failonerror for get dependency job #205

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

renfeiw
Copy link
Contributor

@renfeiw renfeiw commented Jun 8, 2021

Fixes #204

Signed-off-by: renfeiw renfeiw@ca.ibm.com

Fixes adoptium#204

Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
@renfeiw renfeiw requested review from smlambert and llxia June 8, 2021 21:31
@renfeiw
Copy link
Contributor Author

renfeiw commented Jun 8, 2021

run aqa --sdk_resource=nightly --build_list=openjdk --target=sanity --platform=x86-64_linux --jdk_version=11 --jdk_impl=openj9

@renfeiw
Copy link
Contributor Author

renfeiw commented Jun 8, 2021

run aqa --sdk_resource=nightly --build_list=openjdk --target=sanity --platform=x86-64_linux --jdk_version=11 --jdk_impl=hotspot

@karianna karianna added the bug Something isn't working label Jun 8, 2021
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @renfeiw !

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

@renfeiw Build(s) started with the following parameters:

  • sdk_resource: ['nightly']
  • build_repo: ['AdoptOpenJDK/openjdk-build:master']
  • customized_sdk_url: ['None']
  • archive_extension: ['.tar']
  • build_list: ['openjdk']
  • target: ['_sanity']
  • platform: ['ubuntu-latest']
  • jdk_version: ['11']
  • jdk_impl: ['openj9']
  • openjdk_testrepo: ['AdoptOpenJDK/openjdk-tests:master']

Workflow Run ID: 919731358

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

@renfeiw Build(s) started with the following parameters:

  • sdk_resource: ['nightly']
  • build_repo: ['AdoptOpenJDK/openjdk-build:master']
  • customized_sdk_url: ['None']
  • archive_extension: ['.tar']
  • build_list: ['openjdk']
  • target: ['_sanity']
  • platform: ['ubuntu-latest']
  • jdk_version: ['11']
  • jdk_impl: ['hotspot']
  • openjdk_testrepo: ['AdoptOpenJDK/openjdk-tests:master']

Workflow Run ID: 919733353

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

@renfeiw Build(s) failed.
Workflow Run ID: 919731358

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

@renfeiw Build(s) failed.
Workflow Run ID: 919733353

@renfeiw
Copy link
Contributor Author

renfeiw commented Jun 9, 2021

Workflow Run ID: 919731358 was failed as expected, this verifies that failonerror is working.

@renfeiw
Copy link
Contributor Author

renfeiw commented Jun 9, 2021

Workflow Run ID: 919733353 failed is not related. It's an known issue: adoptium/ci-jenkins-pipelines#165

@renfeiw
Copy link
Contributor Author

renfeiw commented Jun 9, 2021

internal grinder passed: /Grinder_TKG/1251

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit beb59e9 into adoptium:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getDependentLibs should fail if the download step fails
4 participants