-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vendor parameters #82
Conversation
Signed-off-by: Shelley Lambert <slambert@gmail.com>
Signed-off-by: Shelley Lambert <slambert@gmail.com>
src/runaqa.ts
Outdated
let vendorRepoParams = '' | ||
let vendorBranchParams = '' | ||
let vendorDirParams = '' | ||
let vendorShaParams = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we could just use one parameter let vendorTestParams = ''
. If any of vendor params is not empty we can appendix the params something like:
if (vendorTestRepos !== '') {
vendorTestParams += ` --vendor_repos ${vendorTestRepos}`
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given it a second thought we may probably move this logic up to aqa.ts run(), which preprocesses all input parameters. So we only need to pass in one parameter instead of four.
Signed-off-by: Shelley Lambert <slambert@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just waiting on adoptium/aqa-tests#2558 to be addressed (which will fix the run-aqa build failures seen in the checks). |
@smlambert merge conflicts |
Signed-off-by: Shelley Lambert <slambert@gmail.com>
This PR depends on adoptium/aqa-tests#2612, shifting to Draft until that is merged. |
Doesn't seem to be in Draft and I can't see a way to do that? |
Signed-off-by: Shelley Lambert <slambert@gmail.com>
Signed-off-by: Shelley Lambert <slambert@gmail.com>
The test failures are all due to the broken jtreg job now... adoptium/ci-jenkins-pipelines#165 (progress!)... |
Signed-off-by: Shelley Lambert <slambert@gmail.com>
This one is ready, the on PR test failing looks like cloning the stf repo failed with some network issue (not related to this change). |
Fixes #79
Fixes #81
Signed-off-by: Shelley Lambert slambert@gmail.com