Backport support for Alpine musl

[calderast]

Apply Alpine's patches with the addition of some small fixes for Alpine musl build support on jdk8u

[karianna]

@gdams - This looks fine to me, quick Q on Git commits. I assume that if/when @calderast submits the upstream patch set it would be easiest for her to do that as the same 2 commits to avoid merge conflicts down the line?

[gdams]

I assume that if/when @calderast submits the upstream patch set it would be easiest for her to do that as the same 2 commits to avoid merge conflicts down the line?

Upstream will likely want the patches in their original form (which we already have in the repo (even if they were rebased)). I'd say this approach is fine, git is usually pretty clever at resolving conflicts like that

[karianna]

Ok let’s get this tested in a pipeline and then we can ship it as a special release after the main batch

On Fri, 21 Jan 2022 at 11:09, George Adams ***@***.***> wrote: I assume that if/when @calderast <https://github.com/calderast> submits the upstream patch set it would be easiest for her to do that as the same 2 commits to avoid merge conflicts down the line? Upstream will likely want the patches in their original form (which we already have in the repo (even if they were rebased)). I'd say this approach is fine, git is usually pretty clever at resolving conflicts like that — Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABME2BNZZD544FJ5KK5LGLUXE5E3ANCNFSM5MOLGX6Q> . You are receiving this because you commented.Message ID: ***@***.***>

-- Cheers, Martijn (Sent from Gmail Mobile)

[gdams]

Thanks for recreating this @calderast. We'll likely have to wait for a few days to merge again until post-release

[gdams]

Alpine JDK8u Job: https://ci.adoptopenjdk.net/job/jdk8-alpine-linux-x64-hotspot/34/
OpenJDK8u Pipeline (other platforms): https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/1968/

[gdams]

@calderast looks like Linux x64 is still failing:

/usr/include/dlfcn.h:74:14: note: previous declaration of 'void* dlvsym(void*, const char*, const char*)'
13:11:03   extern void *dlvsym (void *__restrict __handle,
13:11:03                ^~~~~~
13:11:03  Compiling /home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot/workspace/build/src/hotspot/src/share/vm/opto/parse1.cpp
13:11:03  Compiling /home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot/workspace/build/src/hotspot/src/share/vm/opto/parse2.cpp
13:11:03  /home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot/workspace/build/src/hotspot/make/linux/makefiles/rules.make:149: recipe for target 'os_linux.o' failed
13:11:03  gmake[6]: *** [os_linux.o] Error 1
13:11:03  gmake[6]: *** Waiting for unfinished jobs....
13:11:07  /home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot/workspace/build/src/hotspot/make/linux/makefiles/top.make:119: recipe for target 'the_vm' failed
13:11:07  gmake[5]: *** [the_vm] Error 2
13:11:07  /home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot/workspace/build/src/hotspot/make/linux/Makefile:284: recipe for target 'product' failed
13:11:07  gmake[4]: *** [product] Error 2
13:11:07  Makefile:230: recipe for target 'generic_build2' failed
13:11:07  gmake[3]: *** [generic_build2] Error 2
13:11:07  Makefile:177: recipe for target 'product' failed
13:11:07  gmake[2]: *** [product] Error 2
13:11:07  HotspotWrapper.gmk:44: recipe for target '/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot/workspace/build/src/build/linux-x86_64-normal-server-release/hotspot/_hotspot.timestamp' failed
13:11:07  gmake[1]: *** [/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot/workspace/build/src/build/linux-x86_64-normal-server-release/hotspot/_hotspot.timestamp] Error 2
13:11:07  /home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot/workspace/build/src//make/Main.gmk:109: recipe for target 'hotspot-only' failed

[gdams]

Building again: https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/1975/

@calderast pointed out that I was running against the wrong fork

[gdams]

Running another Pipeline (post rebase) https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/1977/

[gdams]

Running another pipeline: https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/1990
Alpine JDK8u Job: https://ci.adoptopenjdk.net/job/jdk8-alpine-linux-x64-hotspot/35/

[gdams]

Another pipeline run (with the latest changes)
https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/1993/

[gdams]

Kicking off a build with the code set at the most recent JDK8 release so that we can hopefully push out a JDK8 alpine release: https://ci.adoptopenjdk.net/job/jdk8-alpine-linux-x64-hotspot/41/

[gdams]

Link to a pipeline which is passing on all platforms (https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/1995/)

@calderast this is looking good now! I'll request some reviewers

[gdams]

Temurin-Compliance group has determined that more work is required here. Blocking until resolved

[calderast]

Alpine build with the latest changes (https://ci.adoptopenjdk.net/job/jdk8-alpine-linux-x64-hotspot/54/)
Pipeline run for all other platforms (https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/2015/)

[gdams]

Approved - this is no longer a concern to the temurin-compliance group 🎉

[karianna]

@calderast - is this the tidied version your happy to release?

[calderast]

@karianna @gdams PR with cleaner commit history here #9

[gdams]

Superseded by #9