Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a generic name for asm jar #90

Closed
llxia opened this issue Jul 2, 2020 · 1 comment · Fixed by eclipse-openj9/openj9#10116
Closed

Create a generic name for asm jar #90

llxia opened this issue Jul 2, 2020 · 1 comment · Fixed by eclipse-openj9/openj9#10116
Labels
enhancement New feature or request
Milestone
July 2020

Comments

@llxia
Copy link
Contributor

llxia commented Jul 2, 2020

We use asm.jar name contains the specific version.
https://github.com/AdoptOpenJDK/TKG/blob/70d471246847943ac59a8840998c6e625f181056/scripts/getDependencies.pl#L66

The problem is that every time we upgrade the jar, we need to update all the files that use it. (See https://github.com/eclipse/openj9/pull/10057/files)
To avoid this, we should have a generic name (similar to testing, commander, etc). We can just call it asm.jar
@llxia llxia added the enhancement New feature or request label Jul 2, 2020
llxia added a commit to llxia/TKG that referenced this issue Jul 8, 2020
@llxia
Rename asm-8.0.1.jar to asm.jar
7e9e758 
- use a generic name, so we do not need to update all references when we
update this jar

Related: adoptium#90

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@llxia llxia mentioned this issue Jul 8, 2020
Merged
llxia added a commit to llxia/openj9 that referenced this issue Jul 8, 2020
@llxia
Rename asm-8.0.1.jar to asm.jar
79b5d25 
Resolve: adoptium/TKG#90
Related: adoptium/TKG#93

[ci skip]

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@llxia llxia mentioned this issue Jul 8, 2020
Merged
llxia added a commit to llxia/openj9 that referenced this issue Jul 9, 2020
@llxia
Rename asm-8.0.1.jar to asm.jar
c8fb8fa 
Resolve: adoptium/TKG#90
Related: adoptium/TKG#93

[ci skip]

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@karianna karianna added this to the July 2020 milestone Jul 10, 2020
@theresa-m
Copy link
Contributor

good idea @llxia :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
July 2020
Development

Successfully merging a pull request may close this issue.

Rename asm-8.0.1.jar to asm.jar llxia/openj9
3 participants
@karianna @theresa-m @llxia