Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink in status metadata causes YAML parser to report error #91

Closed
socadk opened this issue Jan 19, 2023 · 7 comments · Fixed by #94
Closed

Hyperlink in status metadata causes YAML parser to report error #91

socadk opened this issue Jan 19, 2023 · 7 comments · Fixed by #94

Comments

@socadk
Copy link
Contributor

socadk commented Jan 19, 2023

image

@socadk
Copy link
Contributor Author

socadk commented Jan 19, 2023

Worked around it by replacing []() with <>.

@koppor
Copy link
Member

koppor commented Apr 3, 2023

I added another proposal at #94

@koppor
Copy link
Member

koppor commented Apr 19, 2023

Context: Link probably was https://github.com/adr/madr/blob/main/template/adr-template.md.

@koppor
Copy link
Member

koppor commented Apr 19, 2023

Does not happen today. Thus, we keep everything as is.

@koppor koppor closed this as completed Apr 19, 2023
@kasparkallas
Copy link

kasparkallas commented Apr 24, 2023

Does not happen today. Thus, we keep everything as is.

GitHub is still showing the error: https://github.com/adr/madr/blob/main/template/adr-template.md

EDIT: Oh, it's fine here: https://github.com/adr/madr/blob/main/docs/decisions/adr-template.md

@koppor
Copy link
Member

koppor commented Apr 29, 2023

This is because of the fix of #92.

I also very much dislike that the main branch of the "Successful Git Branching Model" is only shoing releases (see https://nvie.com/posts/a-successful-git-branching-model/).

Maybe, I should just rename "main" to "releases" to be very clear what's happening?

@koppor
Copy link
Member

koppor commented Apr 29, 2023

You can see the really fixed version in the branch develop at https://github.com/adr/madr/blob/develop/template/adr-template.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants