Multiple network provision #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- network name now vagrant-(subnet) - network name configurable in libvirt network definition. Now can insert netowrk name into vm template xml This make the network name changable. - default network domain named something 'default' is better; domain_name is always vagrant.local
Fix problem that nfs export only for ip address where is defined in box.xml, ignoring Vagrantfile's definition. network.rb: - remember machine_ip driver.rb: - introduce read_machine_ip method to get machine ip address from domain and network definition. - This fixes nfs and ssh to access correct ip.
vm_definition: can have multiple nics
network.rb:
- checks 3 types of network options: forwarded, private and public
and treat separately.
- TODO: forwarded_port
- vm can have several private network segments.
each network segment has name 'vagrant-<subnet>'
- TODO: public network.
- add check logic about network segment.
libvirt have a default network segment such as
192.168.122.0 for default/nat and 192.168.100.0 for routing.
driver.rb:
- add_nic (nic) add a nic to vm_definition.
In previous commit, it is introduced that mulple nics with vm_definitions. Notwork definition has also nics definition in order to DHCP returns proper IP address. This fixes network definition can have multiple host definitions.
This modification require for ruby-libvirt 0.5.0 or later that will be support libvirt API virNetworkUpdate It fixes problem when host has same network segment for other vagrant environment or another purpose. It is important feature for multi-network or Multi-VM environment.
KVM can have a network definition without fowarding mode. This means host-only, no nat network definition. VirtualBox don't have this mode basically. Signed-off-by: Hiroshi Miura <miurahr@linux.com>
This was referenced Aug 25, 2013
|
dependency library ruby-libvirt is now under active development; http://libvirt.org/git/?p=ruby-libvirt.git;a=summary |
|
This should fix #49 |
|
This is obsolete and cannot merge recent master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an incomplete multiple private network support modifications.
It could be merged in release AFTER ruby-libvirt 0.5.0 released.
It is necessary to update many part in order to relalize muti-vm multi-net environment. That's because I request early for peer/community review and discussion here.
Comments, Suggestions and requests are welcome!!