Exception on virbr collision

[ghost]

Hi,

ran into this while trying out git master. I had a preexisting
network setup in virt-manager, and this was what I got.
Would be nice to have a better error message.

/home/user1/.vagrant.d/gems/gems/vagrant-kvm-0.1.3/lib/vagrant-kvm/driver/driver.rb:161:in `create': Call to virNetworkCreate failed: internal error Network is already in use by interface virbr1 (Libvirt::Error)
    from /home/user1/.vagrant.d/gems/gems/vagrant-kvm-0.1.3/lib/vagrant-kvm/driver/driver.rb:161:in `create_network'
    from /home/user1/.vagrant.d/gems/gems/vagrant-kvm-0.1.3/lib/vagrant-kvm/action/network.rb:52:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.2.2/lib/vagrant/action/warden.rb:34:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.2.2/lib/vagrant/action/runner.rb:61:in `block in run'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.2.2/lib/vagrant/util/busy.rb:19:in `busy'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.2.2/lib/vagrant/action/runner.rb:61:in `run'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.2.2/lib/vagrant/action/builtin/call.rb:51:in `call'
    from /opt/vagrant/embedded/gems/gems/vagrant-1.2.2/l

[adrahon]

You're right that we need more error checking (and testing to). Thanks for the bug reports, I'll clean that up.

[miurahr]

As an user, it may be better to re-use existing virbrN for creating new virtual network if it is in same subnet.

[miurahr]

I'm working for it now, as one of task to support multi-vm configuration.

[adrahon]

I need to test, but I think this happens when the plugin tries to re-create the "vagrant" network in the same address range as an existing libvirt network.

[miurahr]

#47 may fix this. Hope test on your environment. (warn: need ruby-libvirt 0.5.0 that have not released yet)

[miurahr]

 >I think this happens when the plugin tries to re-create the "vagrant" network in the same address range as an existing libvirt network.

Yes, that's why we need ruby-libvirt 0.5.0 that support 'Update' of existing network that have same address range.

[eagleas]

Hello @miurahr!
ruby-libvirt 0.5.2 is coming out. Need to update dependency in gemspec?

[miurahr]

#111 is marked to merge in 0.1.6.
We are working for 0.1.5 now.

[miurahr]

#111 is merged to master.
@eagleas @y-p could you test it?

There is #184 for multi-vm multi-network. Also you can test.

[miurahr]

Now fix is marged on master.