ENH: user friendly error if there is no loss function #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2020
Closed
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 3 3
Lines 530 532 +2
=======================================
+ Hits 529 531 +2
Misses 1 1
Continue to review full report at Codecov.
|
stsievert
reviewed
Sep 30, 2020
| " compile your model with a loss function within your `model`" | ||
| " model-building method." | ||
| " See https://www.tensorflow.org/api_docs/python/tf/keras/losses" | ||
| " for more information on Keras losses." |
There was a problem hiding this comment.
Style nit: maybe add newlines so the user sees the following?
No valid loss function found. You must provide a loss function to train.
To resolve this issue, do one of the following:
- Provide a loss function via the
lossparameter.- Compile your model with a loss function inside the model-building method.
See https://www.tensorflow.org/api_docs/python/tf/keras/losses Keras loss documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in several previous issues. Checks off a task on #79.
This does not break any APIs because it does not check the
__init__param. Instead it directly checkstf.keras.Model.lossafter the user returns control over to SciKeras.