Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicates in THREAD_TABLE.scad #66

Closed
CrashCash opened this issue Dec 27, 2021 · 2 comments
Closed

Duplicates in THREAD_TABLE.scad #66

CrashCash opened this issue Dec 27, 2021 · 2 comments

Comments

@CrashCash
Copy link

Just wanted to mention a lot of the lines (924 to be exact) in THREAD_TABLE.scad are duplicates. This brings the line count from 2,825 to 1,901.
@adrianschlatter
Copy link
Owner

Indeed. I think that happens when long and short designators of the thread are identical. We should only generate the long descriptor when it is different from the short descriptor.

@adrianschlatter
Copy link
Owner

Fixed in 75814d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CrashCash @adrianschlatter