Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be final since it will not be inherited #140

Open
adriengivry opened this issue Sep 28, 2020 · 0 comments
Open

Should be final since it will not be inherited #140

adriengivry opened this issue Sep 28, 2020 · 0 comments
Labels
Good First Issue An easy issue for new contributors Refactoring Something that needs a refactoring

Comments

@adriengivry
Copy link
Owner

Should be final since it will not be inherited

Originally posted by @litelawliet in #126 (comment)

We should do a pass to ensure classes that should be final to have the final keyword
@adriengivry adriengivry added the Refactoring Something that needs a refactoring label Sep 28, 2020
@maxbrundev maxbrundev added the Good First Issue An easy issue for new contributors label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An easy issue for new contributors Refactoring Something that needs a refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxbrundev @adriengivry