Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace current makefile with something more generic #23

Closed
frangarciam opened this issue Mar 10, 2015 · 2 comments · Fixed by #27
Closed

Replace current makefile with something more generic #23

frangarciam opened this issue Mar 10, 2015 · 2 comments · Fixed by #27

Comments

@frangarciam
Copy link
Contributor

Our current makefile assumes you're developing on a mac, that all your clients will also be macs and that your server is going to be ubuntu (or at least debian) based.

I propose we simplify it and allow it to be more flexible, by ensuring the following:

  • We should be able to build and use hologram just by doing "go get github.com/AdRoll/hologram/..."
  • The build process should be as standard as possible (even getting rid of the dependency for gox, if we can just cross-compile by setting GOOS or using a docker container) so all binaries appear in the expected places.
  • Use our makefile (or rake or whatever) to build rpm/deb/pkg packages for both client and server on demand (but there's no point on building all packages when doing "make")
@frangarciam
Copy link
Contributor Author

#22 is a first step in that direction

@zylad
Copy link
Contributor

zylad commented Mar 10, 2015

I like the overall idea. Also merged #22 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants