Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changes to CHANGELOG.md #5

Closed
ruwaid4 opened this issue Feb 22, 2020 · 0 comments
Closed

Add changes to CHANGELOG.md #5

ruwaid4 opened this issue Feb 22, 2020 · 0 comments

Comments

@ruwaid4
Copy link
Collaborator

ruwaid4 commented Feb 22, 2020

No description provided.

@ruwaid4 ruwaid4 closed this as completed Feb 24, 2020
ruwaid4 pushed a commit that referenced this issue Mar 7, 2020
@adambenali @hanzhsun
@ChangGabriel @jrutqvist @sobolevn
Issue wemake-services#1172 (wemake-services#1199)
cf3aef9 
* Add ExecutableMismatchViolation #9

* Add logic for ExecutableMismatch

* Add WPS452 to test_noqa.py #5

* Remove dependency and related test

* Implement the full checking logic (#13)

* Fix linting problem (#14)

* Clean up code (#15)

Fix checking logic so that we don't thoroughly check every comment

* Fix permissions (#16)

* Make a new visitor to handle files with 0 comments (#17)

* Add tests for ExecutableMismatchViolation (#18)

* Add ExecutableMismatchViolation #9

* Add WPS452 to test_noqa.py #5

* Remove dependency and related test

* Add test resource files from flake8-executable

* Add tests for check_valid_shebang #7

* Implement the full checking logic (#13)

* Fix linting problem (#14)

* Clean up code (#15)

Fix checking logic so that we don't thoroughly check every comment

* Fix permissions (#16)

* Ignore failing test files

* Update test file to be compatible with the new visitor

* Fix linter issues

* Make a new visitor to handle files with 0 comments (#17)

* Exclude test files from linting

Co-authored-by: Hanzhang <48179160+hanzhsun@users.noreply.github.com>
Co-authored-by: jrutqvist <joar.rutqvist@gmail.com>
Co-authored-by: Gabriel Chang <Gc.chang95@gmail.com>

* Update CHANGELOG.md

* Moved test resources to fixtures to be ignored by autopep8

* Add integration test

* Refactor tests

* Make the requested changes
Use temporary files for testing

* Update noqa.py

* Make additional requested changes

* Fix small formatting and typing issues

* Update comments.py

* Update comments.py

Co-authored-by: hanzhsu <emily_1999@link.cuhk.edu.hk>
Co-authored-by: Gabriel Chang <Gc.chang95@gmail.com>
Co-authored-by: Hanzhang <48179160+hanzhsun@users.noreply.github.com>
Co-authored-by: jrutqvist <joar.rutqvist@gmail.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruwaid4