Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu links don't work #21

Open
slsriehl opened this issue Nov 13, 2015 · 7 comments
Open

Menu links don't work #21

slsriehl opened this issue Nov 13, 2015 · 7 comments

Comments

@slsriehl
Copy link

I integrated this solution into my project only to discover that the links in the dropdown mobile menu aren't responding. I didn't touch the javascript and I've been over the css and html several times looking for an explanation. Any ideas?

@arielsalminen
Copy link
Contributor

@slsriehl Do you think you could share the code you are using? I’m wondering if something in the CSS is causing this.

@slsriehl
Copy link
Author

@viljamis Sure, at:
http://www.riehlhelp.com/swg/index.html
http://www.riehlhelp.com/swg/frn/styles.css

The rest fixed-nav files are under their original names at http://www.riehlhelp.com/swg/frn/.

@timi-codes
Copy link

Seriously Battling with the same issue.
I get this in my console when a click on the link
Unable to preventDefault inside passive event listener due to target being treated as passive.
Have you found any fix for this.

@banbanbana
Copy link

Same issue for me. My code is live at www.edgeshelf.com. It only happens when you scroll past one of the areas linked to by the menu (in this case, if I scroll down to the footer past the last menu item, which is "Contact Us"). If I scroll back up into any area linked to by the menu, it works again.

@slsriehl
Copy link
Author

slsriehl commented Jan 5, 2018

I've played around with happybana's code and it seems like the fixed nav links work if the page is positioned more than 62px up from the bottom (62px is also the height of the fixed nav with the page scrolled down). Maybe it's something with the offset, position: fixed, and the scroll event listener.

@banbanbana
Copy link

banbanbana commented Jan 9, 2018

After poking around a bit, I think the issue might be with this line. The second condition is making the scroll stop before the end of the document. Maybe because it doesn't know about the offset in fixed-responsive-nav.js?

scroll.js, line 148
if ( position == endLocation || currentLocation == endLocation || ( (window.innerHeight + currentLocation) >= document.body.scrollHeight ) ) {

@banbanbana
Copy link

For my issue, adding the offset to that line worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants