Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in tube parts of micro-sphere model #33

Closed
adtzlr opened this issue Nov 9, 2021 · 0 comments
Closed

Bug in tube parts of micro-sphere model #33

adtzlr opened this issue Nov 9, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@adtzlr
Copy link
Owner

adtzlr commented Nov 9, 2021

matadi/matadi/models/microsphere/affine/_models.py

Line 26 in 1781804

areastretch = sqrt(diag(r.T @ inv(C) @ r))

matadi/matadi/models/microsphere/nonaffine/_models.py

Line 26 in 1781804

areastretch = sum1(sqrt(diag(r.T @ inv(C) @ r)) ** q * w) ** (1 / q)

replace inv(C) with cof(C) = det(C) * inv(C) because da = cof(F) * dA. In an isochoric-volumetric splitted setting this doesn't matter as det(C) = 1 but this should be changed.
@adtzlr adtzlr added the bug Something isn't working label Nov 9, 2021
@adtzlr adtzlr mentioned this issue Nov 9, 2021
Merged
@adtzlr adtzlr closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adtzlr