Fixed C# project module "AGS.Types" so that it successfully builds in xBuild on *nix systems #396
Conversation
|
Thanks for this and other pull requests.. I'll have to get the build server working again before I can accept them though. |
|
No rush.. I'm still experimenting with the other C# modules. |
|
I apologize for delay, apparently these pull requests fell out of my head completely. Regarding EntryPointOffset which references otherwise unused _entryPointOffset.
This is a caveat of AGS project serialization system, which I do not really like. Something could be done with it later, but for now you may remove this property if you add following attribute to the DialogOption class: [DeserializeIgnore("EntryPointOffset")]
That's an attribute I created while ago for the purpose of deprecating properties without breaking deserialization. |
persn
force-pushed
the
hotfix/ags-types-nix-build
branch
from
b0b5307
to
2c94b56
Compare
File header is commented with /* */ which xbuild doesn't approve of for some reason. I replaced the comments with something more conventional. Alternatively we could also consider to just remove the header entirely, the revision history doesn't provide much substantial information.
Field _editor seems to exist for no other purpose than being assigned to. This needs some testing to verify I didn't break anything in case there's unknown "magic" happening behind somewhere I can't see. As far as I can tell everything is working as it should.
xBuild doesn't approve of unused variable, removed it and a added DeserializeIgnore to class to make sure deserializing doesn't break ggg
persn
force-pushed
the
hotfix/ags-types-nix-build
branch
from
2c94b56
to
1296692
Compare
|
Updated according to feedback |
Like the title says, I have more details on the individual commit messages so make sure to read those.