Fixed C# project module "AGS.CScript.Compiler" so that it successfully builds in xBuild on *nix systems #406
Conversation
| if (helpHandle == null) | ||
| { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I think this meant to compare with 0 (zero handle) instead.
Quote from MSDN:
A process has a main window associated with it only if the process has a graphical interface. If the associated process does not have a main window, the MainWindowHandle value is zero. The value is also zero for processes that have been hidden, that is, processes that are not visible in the taskbar. This can be the case for processes that appear as icons in the notification area, at the far right of the taskbar.
|
I checked this out, and found just two changes that need to be reworked in my opinion. Regarding unused _isLegacyString flag, I do know what that means, but since this compiler is not complete, I cannot tell how it was supposed to be used. If anyone will finish this in the future, they would have to address this issue anyway (assuming legacy strings will still be supported, which is questionable). |
|
E: actually, I rejected one of my comments, noticing that the change only affects local reader object. |
Variable "setEqualTo" is assigned, but value is never used. I quite simply removed the variable assignment. We still need to call the function, as quite lot is happening in the code behind. Variable "memberName" is assigned, but value is never used. There are several TODOs in the code surrounding this variable. I simply commented the variable in case of future needs.
Unused variable. I couldn't find that it did anything and removing it doesn't seem to break anything obvious.
Unused variable. This one seem to had a great deal of thought put into it with a full Enum list to go with it. I decided to fix this by adding a getter just in case.
IntPtr is value type which means it will never be null. We check for IntPtr.Zero instead
Unused variable. Removed it but kept the function call that assigned the variable as there is stuff happening in the code-behind.
persn
force-pushed
the
hotfix/ags-cscript-nix-build
branch
from
eda78e3
to
f76099f
Compare
|
Updated according to feedback and rebased on master. |
Needs #396 to be resolved in order to test properly since AGS.Cscript.Compiler references AGS.Types