Skip to content

PocketMine-MP invalid skin geometry JSON data leading to server crash

High severity GitHub Reviewed Published Aug 16, 2022 in pmmp/PocketMine-MP • Updated Jan 7, 2023

Package

composer pocketmine/pocketmine-mp (Composer)

Affected versions

< 4.7.2

Patched versions

4.7.2

Description

Impact

pocketmine\entity\Skin doesn't correctly handle errors produced by adhocore/json-comment, which throws RuntimeException rather than returning false as PocketMine-MP expects.

This leads to a server crash if the skin geometry data is invalid for some reason (e.g. a syntax error).

Patches

c9626c610b8f6810c8c987559c9197b2a291f0bb

Workarounds

A plugin could handle LoginPacket and PlayerSkinPacket to verify the skin geometry data can be parsed correctly, so that the error condition in the core code is never reached.

For more information

If you have any questions or comments about this advisory:

References

@dktapps dktapps published to pmmp/PocketMine-MP Aug 16, 2022
Published to the GitHub Advisory Database Aug 18, 2022
Reviewed Aug 18, 2022
Last updated Jan 7, 2023

Severity

High
7.5
/ 10

CVSS base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
None
Availability
High
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

Weaknesses

No CWEs

CVE ID

No known CVE

GHSA ID

GHSA-8cwq-4cmf-px73

Source code

Checking history
See something to contribute? Suggest improvements for this vulnerability.