Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: allow or default to use express-fileupload/useTempFiles=true #1817

Closed
mayli opened this issue Jun 4, 2023 · 2 comments · Fixed by #1819
Closed

[Enhancement]: allow or default to use express-fileupload/useTempFiles=true #1817

mayli opened this issue Jun 4, 2023 · 2 comments · Fixed by #1819
Labels
enhancement New feature or request

Comments

@mayli
Copy link
Contributor

mayli commented Jun 4, 2023

Describe the feature/enhancement

https://github.com/richardgirges/express-fileupload/blob/master/README.md

image

ABS actually default to use memory for upload, which isn't quite an option for large audio book collections.
@mayli mayli added the enhancement New feature or request label Jun 4, 2023
@advplyr
Copy link
Owner

advplyr commented Jun 4, 2023

Agree. Related #862

@mayli
Copy link
Contributor Author

mayli commented Jun 4, 2023

Agree. Related #862

I think it's reasonable to have useTempFiles=true, most audiobook file shouldn't really benefit too much to have of them in ram. Will post a PR soon.

@mayli mayli mentioned this issue Jun 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: useTempFiles=true, upload use tmp instead of ram mayli/audiobookshelf
2 participants
@mayli @advplyr