-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop-in component is not keyboard accessible #610
Comments
Hi @Mesoptier, In my opinion the current situation when using the Pay button of the Drop-in works fine. The user can navigate through the payment methods and their fields by pressing Tab , and once they reach to the one they want to use, they can fill the details and press the Pay button. There's no need to jump to the first next element after the Drop-in, since the whole purpose of the Drop-in is to make a payment, and after that the Drop-in should not be there anymore. That being said, I do agree there should be a way to navigate correctly when using a custom Pay button. I'll create an internal ticket to research this and get back to you once we have a solution. Thanks for reaching out and for the detailed report! |
Would like to chime in here that press enter on mobile does not focus the next relevant element. |
@pabloai Any update on this? We have the exact issue as described above. A fix meeting OP's suggested behavior will allow us to meet the Section 2.1 of Web Content Accessibility Guidelines. |
@Mesoptier @jdaily we did improvements on the accessibility of our UI components, and the changes are available in the release 4.9.0. Therefore we are closing this issue for now. Please try it out and feel free to reopen this issue in case you find any other problem related to this topic. And again, thanks for reaching out to us 🙌 |
Describe the bug
There is an accessibility issue with the Adyen Drop-in component: when navigating with the keyboard (using the Tab key) it is not possible to navigate out of the Drop-in without also selecting a different payment method.
To Reproduce
This can easily be reproduced in the example provided with the Drop-in documentation (https://docs.adyen.com/checkout/prebuilt-ui#drop-in):
Expected behavior
What should happen after step 3 (from an accessibility perspective), is for the next focusable element after all payment methods to be focused.
The current behavior makes it practically impossible to use the form with a keyboard, especially if a custom submit button outside of the Drop-in is used (which is officially supported behavior, with the
showPayButton
option).Suggested fix: remove the
tabindex
attribute from the payment method<li>
elements. This would make the Tab behavior work properly. Then, to allow keyboard users to switch between payment methods, standard radio button behavior should be applied to the (currently faked) radio buttons.ScreenshotsScreencastsI recorded a short screencast showing the reproduction steps:
https://www.youtube.com/watch?v=u6Yi-xL4vMU
Desktop (please complete the following information):
Smartphone (please complete the following information):
N/A
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: