Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation unclear about whether icepick adds methods to Object.prototype #19

Closed
danny-andrews opened this issue Jan 20, 2016 · 3 comments

Comments

@danny-andrews
Copy link
Contributor

In the docs, it says seamless-immutable is the most similar to icepick. Its main difference is that it adds more methods to the prototypes of objects, but I was under the impression that icepick didn't add any methods to the prototypes of objects. If that's the case, we should delete the 'more' from above to make that clear.

@aearly
Copy link
Owner

aearly commented Jan 20, 2016

Sure, I was thinking "more" in the context of "in addition to the existing methods" when I wrote that. Feel free to submit a PR if you want. :)

@danny-andrews
Copy link
Contributor Author

Didn't mean to sound persnickety, but adding/modifying built-in methods was a game-changer for me (and I presume many others as well) and I think the fact that this library doesn't do that is a major strength, so I wanted to make sure that was emphasized! Thanks!

@aearly
Copy link
Owner

aearly commented Jan 21, 2016

Thanks! I'm glad you pointed out this point of confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants