merge doesn't work with objects that don't have a prototype.

[ngbrown]

The package query-string is generating objects that have no prototype by using Object.create(null).

I want to deep merge with those objects, but icepick is not thinking they are objects because the isObject test check for prototype.

import {merge} from 'icepick';

// build object like query-string does
let query = Object.create(null);
query['q'] = 'search-term';
const route = {url: './', query: query};

// prepare action for history
const nextPage = merge(route, {query: {page: 2}});

// what I expect to be the result
assert.same(nextPage, {url: './', query: {q: 'search-term', page: 2}});

[aearly]

Ah fascinating! Looks like I could easily change isObject to accept objects with null prototypes, but it might be trickier to return an object that also has a null prototype. Would it be okay to create a vanilla object when it clones?

[ngbrown]

Yes, returning a vanilla (frozen) object is fine. Right now to work around this, I'm rebuild that object before merging. {...query}.