-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main entrypoint not compatible with ES5 #40
Comments
If you want an ES5 version of icepick, I'd use version 1.x, which is fully ES5. You can also configure webpack to use I don't want to ship an ES5 version as the |
Webpack and it's babel plugin should be able to pickup "module" entrypoint, ES6 version, without any configuration. We use browserify + babel 6 and that's much more pain. Having special config with regex pattern to match just one library does not feel good (besides the fact it does not work anyway, but that can be some bug on our side). We switched to icepick 2 because it has dissocIn, is there a chance to backport it to icepick 1? |
Sorry, after more thought, I'm not interested in reverting the |
I know it was done on purpose, but having the "main" entrypoint in package.json pointing to ES6 module is unfortunate. It can't be easily integrated into project that targets older browsers. Babel does not process node_modules by default and having exception for just one library pollutes the build script.
Proposal: Keep main entrypoint ES5, use "module" or "jsnext:main" for ES6
package.json
The text was updated successfully, but these errors were encountered: