New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialogue Display Framework] the dialogue section in the asset entry errors when dialogue isn't specified #68

Open

SinZ163 opened this issue May 21, 2023 · 0 comments

Contributor

SinZ163 commented May 21, 2023

Not my content pack, just passing it on.

https://smapi.io/log/88231f43b5ae4f2dbeb8f352d09195c5

https://smapi.io/json/none/2b4d0cec0e384f1e83bb62efaf886772 (has since changed to use aedenthorn.DialogueDisplayFramework, see #67)

Issue is in the use of GetDataVector without checking whether the data block is null or not, which it is correctly checked everywhere else in the patch
https://github.com/aedenthorn/StardewValleyMods/blob/235c4c7344b2b6270e6f5011c55d36e8a8be9f4e/DialogueDisplayFramework/CodePatches.cs#L363C14-L364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment