Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ph vanishing when the app enter background #381

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix ph vanishing when the app enter background #381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ph/ui/pages/main_page/main_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class PhMainPage extends HookConsumerWidget {
),
const SizedBox(height: 10),
SizedBox(
width: MediaQuery.of(context).size.width - 60,
width: 250,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this on different screen format ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

250 pixels is really small there won't be any problems (I can't really test on little screen format)

child: GestureDetector(
onTap: () {
QR.to(PhRouter.root + PhRouter.past_ph_selection);
Expand Down