Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version advertised by library terminology client #1187

Closed
johngrimes opened this issue Jan 10, 2023 · 3 comments · Fixed by #1189 or #1505
Closed

Wrong version advertised by library terminology client #1187

johngrimes opened this issue Jan 10, 2023 · 3 comments · Fixed by #1189 or #1505
Assignees
Labels
bug Something isn't working
Milestone

Comments

@johngrimes
Copy link
Member

johngrimes commented Jan 10, 2023

It seems like the wrong git.properties file is being picked up from this distribution of the software, probably due to there being multiple within the JAR.

To reproduce this, use the no-argument PathlingContext.create() within the Python library, and take a look at the User-Agent header attached to terminology requests.

@johngrimes johngrimes added the bug Something isn't working label Jan 10, 2023
@johngrimes
Copy link
Member Author

This is again a problem with classpath precedence within the Spark environment.

There are other dependencies within Spark that have git.properties files within them. Setting spark.executor.userClassPathFirst to true fixes the problem.

We might just have add this configuration to the default creation within PathlingContext.create, and also update the guidance for installing in your own cluster / Databricks.

@johngrimes johngrimes self-assigned this Jan 10, 2023
@johngrimes johngrimes changed the title Wrong version advertised when using library API shaded JAR Wrong version advertised by library terminology client Jan 10, 2023
@johngrimes
Copy link
Member Author

This is again a problem due to some subsequent changes in the way that the Spark classpath gets put together in some contexts.

We need a more robust solution to this problem.

@johngrimes
Copy link
Member Author

Fixed in #1189.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
1 participant