Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "dcgoss flavour" of dgoss #427

Merged
merged 4 commits into from May 12, 2019

Conversation

Projects
None yet
2 participants
@fbartels
Copy link
Contributor

commented Mar 19, 2019

I am currently playing with goss and a setup coming from docker-compose. Looking through Github I came across https://github.com/telephoneorg/dcgoss

The Dockerfile in there did not build anymore and the website of the org does not work anymore so it seems this project is not maintained any longer. So I decided to import their latest version (which seems anyways be based on dgoss, although their repo is missing a license file) and merge it with changes from dgoss.

Additionally I let it run through shellcheck and fixed some warnings.

@fbartels fbartels changed the title Add "dcgoss favour" of dgoss Add "dcgoss flavour" of dgoss Mar 19, 2019

@aelsabbahy

This comment has been minimized.

Copy link
Owner

commented Mar 28, 2019

Can you move this to a dcgoss folder and add a brief readme.md.

Doesn't have to be too detailed. The extras are really there for inspiration on ways to use goss.

fbartels added some commits Mar 19, 2019

get in improvements from dgoss
Signed-off-by: Felix Bartels <felix@host-consultants.de>
shellcheck fixes
Signed-off-by: Felix Bartels <felix@host-consultants.de>
move dcgoss into its own directory and add a readme
Signed-off-by: Felix Bartels <felix@host-consultants.de>

@fbartels fbartels force-pushed the fbartels:dcgoss branch from 86e9b00 to c0f89f8 May 1, 2019

@fbartels

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Hi @aelsabbahy,

sorry for the update taking so long. I have now added a readme and moved dcgoss into its own subdir.

@fbartels

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Looking into this again, should I also add this to the travis file? e.g. after https://github.com/aelsabbahy/goss/blob/master/.travis.yml#L28

@aelsabbahy

This comment has been minimized.

Copy link
Owner

commented May 12, 2019

Looks great, and no need to put it in .travis.yml. I don't think I want to package the extras folder as part of goss. dgoss is an exception currently.. but that might not always be the case.

@aelsabbahy aelsabbahy merged commit 641180c into aelsabbahy:master May 12, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@fbartels fbartels deleted the fbartels:dcgoss branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.