Add "dcgoss flavour" of dgoss #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you move this to a dcgoss folder and add a brief readme.md. Doesn't have to be too detailed. The extras are really there for inspiration on ways to use goss. |
…/a7020e46efe09ad74774682bf2ce7ef6ee975381/build/dcgoss Signed-off-by: Felix Bartels <felix@host-consultants.de>
Signed-off-by: Felix Bartels <felix@host-consultants.de>
Signed-off-by: Felix Bartels <felix@host-consultants.de>
Signed-off-by: Felix Bartels <felix@host-consultants.de>
|
Hi @aelsabbahy, sorry for the update taking so long. I have now added a readme and moved dcgoss into its own subdir. |
|
Looking into this again, should I also add this to the travis file? e.g. after https://github.com/aelsabbahy/goss/blob/master/.travis.yml#L28 |
|
Looks great, and no need to put it in .travis.yml. I don't think I want to package the extras folder as part of goss. dgoss is an exception currently.. but that might not always be the case. |
petemounce
pushed a commit
to improbable-eng/goss
that referenced
this pull request
Aug 30, 2019
# By Ahmed Elsabbahy (4) and others # Via Ahmed Elsabbahy * upstream/master: Migrate from dep to go modules. (goss-org#437) Fix systemd service implementation to not fallback to sysv (goss-org#319) (goss-org#374) Fix TCP/DNS examples in the manual (goss-org#429) Handle invalid CLI flags (goss-org#421) Add "dcgoss flavour" of dgoss (goss-org#427) Use most recent docker files Revert "Disable dnstest (goss-org#440)" Account for multiple colon's in dns key (IPv6 PTR) and naive check that qtype matches A-Z (goss-org#441) fix(test): Remove mtu check due to travis changes Add new options to Command resource (goss-org#434) Disable dnstest (goss-org#440) # Conflicts: # .travis.yml # docs/manual.md # integration-tests/test.sh
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* add dcgoss from https://raw.githubusercontent.com/telephoneorg/dcgoss/a7020e46efe09ad74774682bf2ce7ef6ee975381/build/dcgoss Signed-off-by: Felix Bartels <felix@host-consultants.de> * get in improvements from dgoss Signed-off-by: Felix Bartels <felix@host-consultants.de> * shellcheck fixes Signed-off-by: Felix Bartels <felix@host-consultants.de> * move dcgoss into its own directory and add a readme Signed-off-by: Felix Bartels <felix@host-consultants.de>
This was referenced Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently playing with goss and a setup coming from docker-compose. Looking through Github I came across https://github.com/telephoneorg/dcgoss
The Dockerfile in there did not build anymore and the website of the org does not work anymore so it seems this project is not maintained any longer. So I decided to import their latest version (which seems anyways be based on dgoss, although their repo is missing a license file) and merge it with changes from dgoss.
Additionally I let it run through shellcheck and fixed some warnings.