Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of global configs #144

Closed
DDtKey opened this issue May 19, 2023 · 1 comment
Closed

Get rid of global configs #144

DDtKey opened this issue May 19, 2023 · 1 comment

Comments

@DDtKey
Copy link
Contributor

DDtKey commented May 19, 2023

I think it's necessary to drop global configs and move them to structure-based ones.

Motivation: there are cases when an application should use different clients (I mean several fred-clients to different clusters/nodes), and they might have different configs (e.g default_connection_timeout_ms)

@aembke
Copy link
Owner

aembke commented Oct 6, 2023

Most of these were removed in 7.x (https://crates.io/crates/fred/7.0.0-rc.1). I kept a few around that would be especially invasive or annoying to remove, but the important ones were moved to config structs.

@aembke aembke closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants