Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Rationalise matrix profile transformers #833

Open
TonyBagnall opened this issue Oct 13, 2023 · 1 comment
Open

[ENH] Rationalise matrix profile transformers #833

TonyBagnall opened this issue Oct 13, 2023 · 1 comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package

Comments

@TonyBagnall
Copy link
Contributor

TonyBagnall commented Oct 13, 2023

Describe the feature or idea you want to propose

there are two transformers that implement the MatrixProfile. The one in transformations.collections is a bespoke implementation, the one in transformations.series uses (an incorrectly handled) soft dependency. There can be only one

There is also a function MPDist in distances, which uses bespoke operations that are native python. Could be optimised.

Describe your proposed solution

Implement everything with stompy.

we see if they are indeed the same, profile one and then assess alternatives for including MP as a transform.

Describe alternatives you've considered, if relevant

optimise the current implementations

@TonyBagnall TonyBagnall added enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package
Projects
None yet
Development

No branches or pull requests

1 participant