Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update secp256k1 #328

Closed
wants to merge 2 commits into from
Closed

update secp256k1 #328

wants to merge 2 commits into from

Conversation

kroggen
Copy link
Member

@kroggen kroggen commented Nov 28, 2023

This replaces btcd/btcec by dcrec/secp256k1

@kroggen kroggen added dependencies Pull requests that update a dependency file check hardfork Run sync test with the PR labels Nov 28, 2023
@kroggen kroggen mentioned this pull request Nov 28, 2023
Open
@kslee8282
Copy link
Member

[mainnet]
Nov 30 07:57:23.354 INF ../go/aergo/cmd/aergosvr/aergosvr.go:98 > AERGO SVR STARTED branch=topic/update-secp256k1 module=asvr revision=c80bda3f

@kslee8282
Copy link
Member

@kroggen failed sync
Nov 30 08:08:29.736 INF ../go/aergo/syncer/blockprocessor.go:190 > block connect succeed hash=9gqxixNj4rS48ZruRVitmfd5UvBH5iS7JziL4fe4Z1UX module=syncer no=811089
Nov 30 08:08:29.736 INF ../go/aergo/syncer/blockprocessor.go:270 > request connecting block to chainsvc hash=FKtuPKu1BTxPd2swQMn25R53G5qcEtG9FVFNufXRD9aB module=syncer no=811090
Nov 30 08:08:29.736 ERR ../go/aergo/chain/signVerifier.go:87 > error verify tx error="malformed signature: S value has too much padding" hash=6rfj7SVahoGxsQ8HFTZR1uoNC487vGRcSDP4cmaX2n5Z hit=false module=chain worker=6
Nov 30 08:08:29.736 ERR ../go/aergo/chain/signVerifier.go:197 > verifing tx failed error="malformed signature: S value has too much padding" module=chain txno=0
Nov 30 08:08:29.745 ERR ../go/aergo/chain/blockvalidator.go:146 > sign of txs validation failed module=chain
Nov 30 08:08:29.746 ERR ../go/aergo/chain/chainhandle.go:339 > failed to execute block error="Block verify failed" hash=FKtuPKu1BTxPd2swQMn25R53G5qcEtG9FVFNufXRD9aB module=chain
Nov 30 08:08:29.746 ERR ../go/aergo/chain/chainhandle.go:521 > add errored block to errBlocks lru error="Block verify failed" evicted=false hash=FKtuPKu1BTxPd2swQMn25R53G5qcEtG9FVFNufXRD9aB module=chain no=811090
Nov 30 08:08:29.746 ERR ../go/aergo/chain/chainservice.go:651 > failed to add block error="Block verify failed" hash=FKtuPKu1BTxPd2swQMn25R53G5qcEtG9FVFNufXRD9aB module=chain no=811090
Nov 30 08:08:29.746 INF ../go/aergo/syncer/blockprocessor.go:175 > block connect failed error="Block verify failed" hash=FKtuPKu1BTxPd2swQMn25R53G5qcEtG9FVFNufXRD9aB module=syncer no=811090

@kroggen kroggen mentioned this pull request Dec 1, 2023
Open
@kroggen
Copy link
Member Author

kroggen commented Dec 13, 2023

This was discarded in favor of PR 330

@kroggen kroggen closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayarobi hayarobi Awaiting requested review from hayarobi

@rabbitprincess rabbitprincess Awaiting requested review from rabbitprincess

Assignees
No one assigned
Labels
check hardfork Run sync test with the PR dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kroggen @kslee8282