Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update btcec #330

Open
wants to merge 5 commits into
base: feature/updateLibP2P
Choose a base branch
from
Open

update btcec #330

wants to merge 5 commits into from

Conversation

kroggen
Copy link
Member

@kroggen kroggen commented Dec 1, 2023

  • Update btcec to v2
  • Remove btcd dependency

This PR is based on the feature/updateLibP2P branch from PR #327

It can be merged into that branch (will appear on the other PR) or into the develop branch (after the other PR is merged)

This PR replaces #328

hayarobi and others added 5 commits November 28, 2023 16:57
@hayarobi
update dependency on libp2p from 0.4.0 to 0.32.1
3bd6fd0 
- Fixed code that was not backward compatible due to the interface change.
- Fixed failed unit tests.
- Regenerate mock classes with newer gomock version.
- Improved documents of code generations of mock classes.
@hayarobi
Fix go version to build and test
2d0deb6
@hayarobi
Fix version of golang again.
113190a
@kroggen
update btcec and remove btcd
fbd9f9d
@kroggen
fix tests
3120a69
@kroggen kroggen added dependencies Pull requests that update a dependency file check hardfork Run sync test with the PR labels Dec 1, 2023
@kslee8282
Copy link
Member

Dec 2 00:21:28.232 INF ../go/aergo/p2p/transport/networktransport.go:124 > Error while get stream error="failed to dial: failed to dial 16Uiu2HAmRCvmFQANpSAgZGdTTXJRt3V3UX7BjxL8SYMdv9sc2W81: all dials failed\n * [/ip4/15.165.32.166/tcp/7846] failed to negotiate security protocol: protocols not supported: [/noise /tls/1.0.0]" addr=/ip4/15.165.32.166/tcp/7846 module=p2p p2p_proto=[/aergop2p] peer_id=16sc2W81
Dec 2 00:21:28.232 INF ../go/aergo/p2p/waitpeermanager.go:171 > Failed to get stream. error="failed to dial: failed to dial 16Uiu2HAmRCvmFQANpSAgZGdTTXJRt3V3UX7BjxL8SYMdv9sc2W81: all dials failed\n * [/ip4/15.165.32.166/tcp/7846] failed to negotiate security protocol: protocols not supported: [/noise /tls/1.0.0]" module=p2p peer_id=16sc2W81

@hayarobi
Copy link
Member

hayarobi commented Dec 2, 2023

#327 is not finished yet, since it need to correct polaris connection issue mentioned by @kslee. If this PR is strongly tied to #327, you will need to rebase this branch on develop after merging #327.

@hayarobi hayarobi force-pushed the feature/updateLibP2P branch 2 times, most recently from 8bb7de5 to ca26f63 Compare December 11, 2023 03:00
@hayarobi
Copy link
Member

We need to wait, since go-libp2p v0.14.4 in #337 still requires btcd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayarobi hayarobi Awaiting requested review from hayarobi

@rabbitprincess rabbitprincess Awaiting requested review from rabbitprincess

Assignees
No one assigned
Labels
check hardfork Run sync test with the PR dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kroggen @kslee8282 @hayarobi