Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LEGACY ISSUE 271] Paloalto generator should provide more informational/warning logs #48

Closed
ankenyr opened this issue Oct 26, 2022 · 3 comments
Closed

[LEGACY ISSUE 271] Paloalto generator should provide more informational/warning logs #48

ankenyr opened this issue Oct 26, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@ankenyr
Copy link
Collaborator

ankenyr commented Oct 26, 2022

No description provided.

@ankenyr
Copy link
Collaborator Author

ankenyr commented Oct 27, 2022

This one calls out warnings and informational logs. @jtwb what do you think about the current state of logging within Aerleon?

The author points out a few locations that additional logging could be inserted but it is not an exhaustive list.

@ankenyr ankenyr added the enhancement New feature or request label Oct 27, 2022
@ankenyr
Copy link
Collaborator Author

ankenyr commented Nov 30, 2022

Generally I think this comment was misguided. The sections the author points to don't generally line up to sections that remove things. I think this can be closed as won't fix.

@ankenyr ankenyr closed this as completed Nov 30, 2022
@ankenyr
Copy link
Collaborator Author

ankenyr commented Nov 30, 2022

To note, I have found debug logs that should be warnings or info. That is a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ankenyr