Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability to automatically download driver binaries and set up Selenoid for local development #4

Closed
vania-pooh opened this issue Apr 21, 2017 · 8 comments
Milestone

Comments

@vania-pooh
Copy link
Member

This is needed for local development when user does not want to install Docker. In that case we download latest driver binaries and configure Selenoid to launch them directly as processes.

@vania-pooh vania-pooh added this to the 1.1.0 milestone Apr 21, 2017
@vania-pooh
Copy link
Member Author

Need to store somewhere an XML file with browser - driver version compatibility table and download it during command run.

@vania-pooh
Copy link
Member Author

This one seems to be quite complex and difficult to maintain. Closing in favor to aerokube/selenoid#58.

@lanwen
Copy link
Contributor

lanwen commented May 11, 2017

@lanwen lanwen reopened this May 11, 2017
@vania-pooh
Copy link
Member Author

vania-pooh commented May 11, 2017

This shit only supports the latest version of driver. Correct solution is to support browser version - driver version mapping, determine actual browser version, store urls to driver binaries for different platforms and architectures, and so on and so forth. Maintaining such lists is error prone and requires implementing tests that check URLs for errors. So yes, we can just repeat these ones and this is simple. But in fact it's an ugly handicraft.

@vania-pooh
Copy link
Member Author

An incomplete mapping file can found here: https://github.com/vania-pooh/cm/blob/master/browsers.json

@vania-pooh
Copy link
Member Author

Some draft of this functionality is here: https://github.com/vania-pooh/cm/blob/master/selenoid/drivers.go

@lanwen
Copy link
Contributor

lanwen commented May 11, 2017

For the most situations people don't need (and don't know about) versions. Just latest working

@lanwen
Copy link
Contributor

lanwen commented May 14, 2017

One more example:
https://github.com/bonigarcia/webdrivermanager

aandryashin added a commit that referenced this issue Jun 3, 2017
Added capability to automatically download binaries (fixes #4, #5, #11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants