Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly processing deviceName capability in /status API and S3 uplo… #787

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

vania-pooh
Copy link
Member

…ading (fixes #785)

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #787 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files          12       12           
  Lines        1494     1494           
=======================================
  Hits         1153     1153           
  Misses        262      262           
  Partials       79       79
Flag Coverage Δ
#unittests 77.17% <100%> (ø) ⬆️
Impacted Files Coverage Δ
config/config.go 97.46% <100%> (ø) ⬆️
session/session.go 94.44% <100%> (+0.89%) ⬆️
service/service.go 72.91% <100%> (-2.56%) ⬇️
selenoid.go 87.79% <100%> (ø) ⬆️
upload/s3.go 83.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c70ce6...da60937. Read the comment docs.

@vania-pooh vania-pooh merged commit db901aa into aerokube:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/status API returns empty browser name with deviceName capability
1 participant