Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend getMyLooms with metadats #15

Closed
dweemx opened this issue Feb 19, 2018 · 5 comments
Closed

extend getMyLooms with metadats #15

dweemx opened this issue Feb 19, 2018 · 5 comments
Assignees
@KrisDavie
Labels
backend enhancement New feature or request question Further information is requested

Comments

@dweemx
Copy link
Contributor

dweemx commented Feb 19, 2018

We have to deal and warn the user when loom files are invalid/corrupted or valid but don't have the extended version of the loom (e.g.: RegulonsAUC not present or any other attributes not present). How should we do this?
@dweemx dweemx added the question Further information is requested label Feb 19, 2018
@KrisDavie
Copy link
Contributor

I think it would be a good idea to do this: When a loom file is loaded, the backend checks for which attributes are available (i.e. regulon data, cluster markers etc.), this data is sent back to the frontend which then enables/disables the related tabs.

Thoughts?

@kreftl
Copy link

kreftl commented Feb 19, 2018

yep, i would extend the getMyLooms function with some has.... booleans, that can steer the frontend accordingly (e.g. hasRegulonsAUC )

@kreftl
Copy link

kreftl commented Feb 20, 2018 •
edited
Loading

also include the metadata containing subsets (e.g. tSNE coordinates serrat/scenic) and clustering, ageing annotations

@kreftl kreftl changed the title how to deal with invalid/corrupted or unextended loom files? extend getMyLooms with metadats Feb 20, 2018
@kreftl kreftl mentioned this issue Feb 20, 2018
Closed
@kreftl kreftl added enhancement New feature or request backend labels Feb 20, 2018
@KrisDavie
Copy link
Contributor

KrisDavie commented Feb 21, 2018 •
edited
Loading

partially resolved in 580017d

@KrisDavie KrisDavie reopened this Feb 21, 2018
@KrisDavie KrisDavie self-assigned this Feb 21, 2018
@KrisDavie
Copy link
Contributor

fully resolved in f300c82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrisDavie KrisDavie

Labels
backend enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KrisDavie @dweemx @kreftl