Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set filterwarnings to error in the tests #54

Closed
brandonwillard opened this issue Aug 22, 2022 · 1 comment
Closed

Set filterwarnings to error in the tests #54

brandonwillard opened this issue Aug 22, 2022 · 1 comment
Labels
bug Something isn't working important testing

Comments

@brandonwillard
Copy link
Member

Our tests should not allow un-caught/checked warnings.

The addition to setup.cfg mentioned here should be sufficient. We'll need to update our tests to prevent them from failing, though.
@brandonwillard brandonwillard added bug Something isn't working important testing labels Aug 22, 2022
@rlouf
Copy link
Member

rlouf commented Sep 21, 2022

Addressed in e0336b6

@rlouf rlouf closed this as completed Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working important testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonwillard @rlouf